Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-22 Thread Szabolcs Nagy
On 21/11/16 14:16, FX wrote: > Can you XFAIL the test on your platform, open a PR and assign it to me? OK. Committed. ARM and AArch64 may not support trapping so runtime and compile time check can differ. gcc/testsuite/ 2016-11-22 Szabolcs Nagy PR libgfortran/78449 * gfortran

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-21 Thread Szabolcs Nagy
On 21/11/16 14:16, FX wrote: >> it seems this broke ieee_8.f90 which tests compile time vs runtime value of >> ieee_support_halting >> if fortran needs this, then support_halting should be always false on arm >> and aarch64. >> but i'm not familiar enough with fortran to tell if there is some bet

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-21 Thread FX
Dear Nagy, > it seems this broke ieee_8.f90 which tests compile time vs runtime value of > ieee_support_halting > if fortran needs this, then support_halting should be always false on arm and > aarch64. > but i'm not familiar enough with fortran to tell if there is some better > workaround. Ca

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-18 Thread Szabolcs Nagy
On 16/11/16 16:53, Szabolcs Nagy wrote: > ieee_support_halting only checked the availability of status > flags, not trapping support. On some targets the later can > only be checked at runtime: feenableexcept reports if > enabling traps failed. > > So check trapping support by enabling/disabling

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-16 Thread FX
> gcc/testsuite/ > 2016-11-16 Szabolcs Nagy > > PR libgfortran/78314 > * gfortran.dg/ieee/ieee_6.f90: Use ieee_support_halting. > > libgfortran/ > 2016-11-16 Szabolcs Nagy > > PR libgfortran/78314 > * config/fpu-glibc.h (support_fpu_trap): Use feenableexcept. OK to

[PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-16 Thread Szabolcs Nagy
ieee_support_halting only checked the availability of status flags, not trapping support. On some targets the later can only be checked at runtime: feenableexcept reports if enabling traps failed. So check trapping support by enabling/disabling it. Updated the test that enabled trapping to check