Re: [PATCH v2, rs6000] Put dg-options before effective target checks

Hi! On Fri, Sep 02, 2022 at 11:43:28AM +0800, HAO CHEN GUI wrote: > On 2/9/2022 上午 12:07, Segher Boessenkool wrote: > >> +/* { dg-do compile { target { ! has_arch_pwr9 } } } */ > > Please keep dg-do first thing in the file. > Could you inform me if it's a must to put dg-do in the first line? It i

Re: [PATCH v2, rs6000] Put dg-options before effective target checks

on 2022/9/2 11:23, HAO CHEN GUI wrote: > Hi Kewen, > > On 1/9/2022 下午 5:34, Kewen.Lin wrote: >> Thanks for the updated patch! >> >> I just found that it seems all the three test cases suffer the empty >> TU error issue from those has_arch* effective target checks? >> >> If yes, it looks we don't n

Re: [PATCH v2, rs6000] Put dg-options before effective target checks

Hi Segher, Thanks for your review comments. I will refine it according to your comments. On 2/9/2022 上午 12:07, Segher Boessenkool wrote: >> +/* { dg-do compile { target { ! has_arch_pwr9 } } } */ > Please keep dg-do first thing in the file. Could you inform me if it's a must to put dg-do in the

Re: [PATCH v2, rs6000] Put dg-options before effective target checks

Hi Kewen, On 1/9/2022 下午 5:34, Kewen.Lin wrote: > Thanks for the updated patch! > > I just found that it seems all the three test cases suffer the empty > TU error issue from those has_arch* effective target checks? > > If yes, it looks we don't need to bother this once patch [1] gets > landed?

Re: [PATCH v2, rs6000] Put dg-options before effective target checks

On Thu, Sep 01, 2022 at 01:30:18PM +0800, HAO CHEN GUI wrote: > --- a/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c > @@ -1,6 +1,10 @@ > -/* { dg-do compile { target { lp64 && has_arch_pwr9 } } } */ > +/* { dg-do compile } */ > +/* { dg-option

Re: [PATCH v2, rs6000] Put dg-options before effective target checks

Hi Haochen, on 2022/9/1 13:30, HAO CHEN GUI wrote: > Hi, > This patch changes the sequence of test directives for 3 test cases. > Originally, these 3 cases got failed or unsupported on some platforms, as > their effective target checks depend on compiling options. > Thanks for the updated patc

[PATCH v2, rs6000] Put dg-options before effective target checks

Hi, This patch changes the sequence of test directives for 3 test cases. Originally, these 3 cases got failed or unsupported on some platforms, as their effective target checks depend on compiling options. Bootstrapped and tested on powerpc64-linux BE and LE with no regressions. Is this okay f