Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Ian Lance Taylor
On Tue, Oct 2, 2012 at 10:48 AM, Uros Bizjak wrote: > On Tue, Oct 2, 2012 at 7:44 PM, Gabriel Dos Reis > wrote: > > On a related issue, it looks to me that the compiler itself should be > compiled with -funwind-tables, otherwise there are no backtraces > generated, even if libbackt

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Uros Bizjak
On Tue, Oct 2, 2012 at 7:44 PM, Gabriel Dos Reis wrote: >>> > On a related issue, it looks to me that the compiler itself should be >>> > compiled with -funwind-tables, otherwise there are no backtraces >>> > generated, even if libbacktrace is linked in and operational. Again, >>> > x86_64-linux-

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Gabriel Dos Reis
On Tue, Oct 2, 2012 at 12:14 PM, Jakub Jelinek wrote: > On Tue, Oct 02, 2012 at 10:12:38AM -0700, Ian Lance Taylor wrote: >> On Tue, Oct 2, 2012 at 8:22 AM, Uros Bizjak wrote: >> > >> > On a related issue, it looks to me that the compiler itself should be >> > compiled with -funwind-tables, other

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Jakub Jelinek
On Tue, Oct 02, 2012 at 10:12:38AM -0700, Ian Lance Taylor wrote: > On Tue, Oct 2, 2012 at 8:22 AM, Uros Bizjak wrote: > > > > On a related issue, it looks to me that the compiler itself should be > > compiled with -funwind-tables, otherwise there are no backtraces > > generated, even if libbacktr

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Ian Lance Taylor
On Tue, Oct 2, 2012 at 8:22 AM, Uros Bizjak wrote: > > On a related issue, it looks to me that the compiler itself should be > compiled with -funwind-tables, otherwise there are no backtraces > generated, even if libbacktrace is linked in and operational. Again, > x86_64-linux-gnu host defaults to

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Uros Bizjak
On Tue, Oct 2, 2012 at 3:08 PM, Ian Lance Taylor wrote: >> 2012-10-02 Uros Bizjak >> >> PR other/54761 >> * configure.ac (EXTRA_FLAGS): New. >> * Makefile.am (AM_FLAGS): Add $(EXTRA_FLAGS). >> * configure, Makefile.in: Regenerate. > > This is OK. Thanks, committ

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Ian Lance Taylor
On Tue, Oct 2, 2012 at 2:01 AM, Uros Bizjak wrote: > > 2012-10-02 Uros Bizjak > > PR other/54761 > * configure.ac (EXTRA_FLAGS): New. > * Makefile.am (AM_FLAGS): Add $(EXTRA_FLAGS). > * configure, Makefile.in: Regenerate. This is OK. Thanks. Ian

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Uros Bizjak
On Tue, Oct 2, 2012 at 10:08 AM, Andreas Schwab wrote: >> +if test "x$GCC" = "xyes"; then >> + CFLAGS="$CFLAGS -funwind-tables" >> +fi >> + > > Don't modify CFLAGS, instead you should substitute a new variable that > is added to AM_CFLAGS. CFLAGS is reserved for the user to override. Thanks, a

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Andreas Schwab
Uros Bizjak writes: > Index: configure.ac > === > --- configure.ac (revision 191953) > +++ configure.ac (working copy) > @@ -66,6 +66,10 @@ > AC_PROG_CC > m4_rename_force([backtrace_PRECIOUS],[_AC_ARG_VAR_PRECIOUS]) > >

[PATCH v2, libbacktrace]: Compile with -funwind-tables

2012-10-02 Thread Uros Bizjak
On Tue, Oct 2, 2012 at 12:58 AM, Ian Lance Taylor wrote: >> Without -fasynchronous-unwind-tables, FDE is not generated for >> backtrace_full and backtrace_simple wrappers. Without FDE, unwinding >> terminates at these functions. > > I'm not opposed to -fasynchronous-unwind-tables, but now that yo