Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-15 Thread Jonathan Wakely via Gcc-patches
On 12/03/21 15:33 -0800, Caroline Tice wrote: I have updated the patch as you suggested, to filter the "-fvtable-verify=std" out of AM_CXXFLAGS, and I have verified that it passes the testsuite with no regressions and fixes the reported bug. This means we also don't pass it to LTCXXCOMPILE, ins

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-12 Thread Caroline Tice via Gcc-patches
I have updated the patch as you suggested, to filter the "-fvtable-verify=std" out of AM_CXXFLAGS, and I have verified that it passes the testsuite with no regressions and fixes the reported bug. Is this OK to commit now? -- Caroline Tice cmt...@google.com libstdc++-v3/ChangeLog 2021-03-12 Car

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-11 Thread Jonathan Wakely via Gcc-patches
On 11/03/21 17:46 +0100, Jakub Jelinek via Libstdc++ wrote: On Thu, Mar 11, 2021 at 04:31:51PM +, Jonathan Wakely via Gcc-patches wrote: On 11/03/21 16:27 +, Jonathan Wakely wrote: > That seems cleaner to me, rather than adding another variable with > minor differences from the existing

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-11 Thread Jakub Jelinek via Gcc-patches
On Thu, Mar 11, 2021 at 04:31:51PM +, Jonathan Wakely via Gcc-patches wrote: > On 11/03/21 16:27 +, Jonathan Wakely wrote: > > That seems cleaner to me, rather than adding another variable with > > minor differences from the existing AM_CXXFLAGS. > > My specific concern is that AM_CXXFLAGS

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-11 Thread Jonathan Wakely via Gcc-patches
On 11/03/21 16:27 +, Jonathan Wakely wrote: That seems cleaner to me, rather than adding another variable with minor differences from the existing AM_CXXFLAGS. My specific concern is that AM_CXXFLAGS and AM_CXXFLAGS_LT will get out of sync, i.e. we'll add something to the former and forget

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-11 Thread Jonathan Wakely via Gcc-patches
On 11/03/21 07:31 -0800, Caroline Tice via Libstdc++ wrote: Adding the libstdc++ mailing list to the patch. Thanks. -- Caroline cmt...@google.com On Wed, Mar 10, 2021 at 8:50 PM Caroline Tice wrote: This patch is to fix PR 99172. Currently when GCC is configured with --enable-vtable-veri

Re: [PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-11 Thread Caroline Tice via Gcc-patches
Adding the libstdc++ mailing list to the patch. -- Caroline cmt...@google.com On Wed, Mar 10, 2021 at 8:50 PM Caroline Tice wrote: > > This patch is to fix PR 99172. > > Currently when GCC is configured with --enable-vtable-verify, the > libstdc++-v3 Makefiles add "-fvtable-verify=std > -Wl,-u_v

[PATCH v1] libstdc++-v3: Update VTV vars for libtool link commands [PR99172]

2021-03-10 Thread Caroline Tice via Gcc-patches
This patch is to fix PR 99172. Currently when GCC is configured with --enable-vtable-verify, the libstdc++-v3 Makefiles add "-fvtable-verify=std -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end" to libtool link commands. The "-fvtable-verify=std" piece causes alternate versions of libtool (such