Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Luc Grosheintz
On 5/15/25 5:12 PM, Jonathan Wakely wrote: On Thu, 15 May 2025 at 16:12, Jonathan Wakely wrote: On Thu, 15 May 2025 at 16:11, Luc Grosheintz wrote: Without would make sense to me, because whenever I wrote an identifier with _ I felt like I was presenting the user with a name that they sh

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Jonathan Wakely
On Thu, 15 May 2025 at 16:12, Jonathan Wakely wrote: > > On Thu, 15 May 2025 at 16:11, Luc Grosheintz wrote: > > > > Without would make sense to me, because whenever I wrote an > > identifier with _ I felt like I was presenting the user with > > a name that they shouldn't know about. > > > > A pe

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Jonathan Wakely
On Thu, 15 May 2025 at 16:11, Luc Grosheintz wrote: > > Without would make sense to me, because whenever I wrote an > identifier with _ I felt like I was presenting the user with > a name that they shouldn't know about. > > A pedantic question: Can I also fix the line below, or do > you prefer to

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Luc Grosheintz
Without would make sense to me, because whenever I wrote an identifier with _ I felt like I was presenting the user with a name that they shouldn't know about. A pedantic question: Can I also fix the line below, or do you prefer to be strict about one semantic change per commit? On 5/15/25 2:40

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Tomasz Kaminski
No strong preference, but Ville's argument sounds reasonable. On Thu, May 15, 2025 at 12:25 PM Ville Voutilainen < ville.voutilai...@gmail.com> wrote: > Mild preference against; use the names from the standard, not the > implementation, in such diagnostics. > > to 15. toukok. 2025 klo 13.20 Jonat

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Ville Voutilainen
Mild preference against; use the names from the standard, not the implementation, in such diagnostics. to 15. toukok. 2025 klo 13.20 Jonathan Wakely kirjoitti: > On Thu, 15 May 2025 at 11:14, Jonathan Wakely wrote: > > > > On Wed, 14 May 2025 at 20:18, Luc Grosheintz > wrote: > > > > > > The s

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Jonathan Wakely
On Thu, 15 May 2025 at 11:14, Jonathan Wakely wrote: > > On Wed, 14 May 2025 at 20:18, Luc Grosheintz wrote: > > > > The standard states that the IndexType must be a signed or unsigned > > integer. This mandate was implemented using `std::is_integral_v`. Which > > also includes (among others) cha

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Jonathan Wakely
On Wed, 14 May 2025 at 20:18, Luc Grosheintz wrote: > > The standard states that the IndexType must be a signed or unsigned > integer. This mandate was implemented using `std::is_integral_v`. Which > also includes (among others) char and bool, which neither signed nor > unsigned integers. > > libs

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-15 Thread Tomasz Kaminski
On Wed, May 14, 2025 at 9:18 PM Luc Grosheintz wrote: > The standard states that the IndexType must be a signed or unsigned > integer. This mandate was implemented using `std::is_integral_v`. Which > also includes (among others) char and bool, which neither signed nor > unsigned integers. > > lib

Re: [PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-14 Thread Luc Grosheintz
To make review easier, I'd like to provide links to the sections in the standard I used. mandate: https://eel.is/c++draft/mdspan.extents#overview-1.1 signed integer: https://eel.is/c++draft/basic.fundamental#1 unsigned integer: https://eel.is/c++draft/basic.fundamental#2 integral: https://eel.i

[PATCH v1] libstdc++: Fix class mandate for extents.

2025-05-14 Thread Luc Grosheintz
The standard states that the IndexType must be a signed or unsigned integer. This mandate was implemented using `std::is_integral_v`. Which also includes (among others) char and bool, which neither signed nor unsigned integers. libstdc++-v3/ChangeLog: * include/std/mdspan: Implement the m