Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2014-01-30 Thread H.J. Lu
On Thu, Jan 30, 2014 at 12:36 PM, Ilya Verbin wrote: > 2014-01-30 H.J. Lu : >>> + { OPTION_MASK_ISA_SSE2, CODE_FOR_sha256rnds2, 0, >>> IX86_BUILTIN_SHA256RNDS2, UNKNOWN, (int) V4SI_FTYPE_V4SI_V4SI_V4SI }, >> ^ Is OPTION_MASK_ISA_SSE2 >> intentional? >> Sh

Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2014-01-30 Thread Ilya Verbin
2014-01-30 H.J. Lu : >> + { OPTION_MASK_ISA_SSE2, CODE_FOR_sha256rnds2, 0, >> IX86_BUILTIN_SHA256RNDS2, UNKNOWN, (int) V4SI_FTYPE_V4SI_V4SI_V4SI }, > ^ Is OPTION_MASK_ISA_SSE2 intentional? > Should it be OPTION_MASK_ISA_SHA? > -- > H.J. This was done by an

Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2014-01-30 Thread H.J. Lu
On Mon, Dec 30, 2013 at 4:55 AM, Kirill Yukhin wrote: > Hello, > On 19 Nov 15:36, Uros Bizjak wrote: >> Please also add new command options to g++.dg/other/sse-2.C and >> g++.dg/other/sse-3.C > Done (to i386-[23].C). >> > --mavx2 -mavx512f -mavx512pf -mavx512er -mavx512cd @gol >> > +-mavx2 -mavx51

Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2013-12-30 Thread Kirill Yukhin
Hello, On 19 Nov 15:36, Uros Bizjak wrote: > Please also add new command options to g++.dg/other/sse-2.C and > g++.dg/other/sse-3.C Done (to i386-[23].C). > > --mavx2 -mavx512f -mavx512pf -mavx512er -mavx512cd @gol > > +-mavx2 -mavx512f -mavx512pf -mavx512er -mavx512cd -msha -mno-sha @gol > > No n

Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2013-11-20 Thread Kirill Yukhin
On 19 Nov 15:36, Uros Bizjak wrote: > Please also add new command options to g++.dg/other/sse-2.C and > g++.dg/other/sse-3.C > > OK with the small nit below and with above testsute addition. > > No need to document negative option here. Thanks! I'll fix your inputs and check in after rest is rev

Re: [PATCH i386 8/8] [AVX-512] Add SHA support.

2013-11-19 Thread Uros Bizjak
On Tue, Nov 19, 2013 at 1:41 PM, Kirill Yukhin wrote: > Hello, > This patch introduces new SHA instructions described in [1] > along with tests. > > Testing: > 1. Bootstrap pass. > 2. make check shows no regressions. > 3. Spec 2000 & 2006 build show no regressions both with and without > -m

[PATCH i386 8/8] [AVX-512] Add SHA support.

2013-11-19 Thread Kirill Yukhin
Hello, This patch introduces new SHA instructions described in [1] along with tests. Testing: 1. Bootstrap pass. 2. make check shows no regressions. 3. Spec 2000 & 2006 build show no regressions both with and without -mavx512f option. 4. Spec 2000 & 2006 run shows no stability regressions