Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-11-07 Thread Eric Botcazou
> 2011-11-06 Sergey Ostanevich sergos@gmail.com > > PR rtl-optimization/47698 > * ifconv.c (noce_operand_ok): prevent CMOV generation > for volatile mem There is no such file as ifconv.c though. The first letter must be capitalized and there must be a period at the end. A

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-11-06 Thread Sergey Ostanevich
On Wed, Nov 2, 2011 at 3:42 PM, Richard Guenther wrote: > On Sat, 29 Oct 2011, Sergey Ostanevich wrote: > >> On Fri, Oct 28, 2011 at 7:25 PM, Sergey Ostanevich >> wrote: >> > On Fri, Oct 28, 2011 at 4:52 PM, Richard Guenther >> > wrote: >> >> On Fri, 28 Oct 2011, Sergey Ostanevich wrote: >> >>

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-11-02 Thread Richard Guenther
On Sat, 29 Oct 2011, Sergey Ostanevich wrote: > On Fri, Oct 28, 2011 at 7:25 PM, Sergey Ostanevich > wrote: > > On Fri, Oct 28, 2011 at 4:52 PM, Richard Guenther wrote: > >> On Fri, 28 Oct 2011, Sergey Ostanevich wrote: > >> > >>> On Fri, Oct 28, 2011 at 12:16 PM, Richard Guenther > >>> wrote

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Sergey Ostanevich
On Fri, Oct 28, 2011 at 7:25 PM, Sergey Ostanevich wrote: > On Fri, Oct 28, 2011 at 4:52 PM, Richard Guenther wrote: >> On Fri, 28 Oct 2011, Sergey Ostanevich wrote: >> >>> On Fri, Oct 28, 2011 at 12:16 PM, Richard Guenther >>> wrote: >>> > On Thu, 27 Oct 2011, Uros Bizjak wrote: >>> > >>> >> H

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Richard Henderson
On 10/28/2011 05:49 AM, Sergey Ostanevich wrote: > - the code for CMOV is under #ifdef in the mddle-end, which is > explicitly marked as "have to be removed" (ifcvt.c:1446) > - I have no clear evidence all platforms that support conditional move > have the same semantics that lead to the PR We're

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Sergey Ostanevich
On Fri, Oct 28, 2011 at 4:52 PM, Richard Guenther wrote: > On Fri, 28 Oct 2011, Sergey Ostanevich wrote: > >> On Fri, Oct 28, 2011 at 12:16 PM, Richard Guenther wrote: >> > On Thu, 27 Oct 2011, Uros Bizjak wrote: >> > >> >> Hello! >> >> >> >> > Here's a patch for PR47698, which is about CMOV shou

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Richard Guenther
On Fri, 28 Oct 2011, Sergey Ostanevich wrote: > On Fri, Oct 28, 2011 at 12:16 PM, Richard Guenther wrote: > > On Thu, 27 Oct 2011, Uros Bizjak wrote: > > > >> Hello! > >> > >> > Here's a patch for PR47698, which is about CMOV should not be > >> > generated for memory address marked as volatile. >

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Sergey Ostanevich
On Fri, Oct 28, 2011 at 12:16 PM, Richard Guenther wrote: > On Thu, 27 Oct 2011, Uros Bizjak wrote: > >> Hello! >> >> > Here's a patch for PR47698, which is about CMOV should not be >> > generated for memory address marked as volatile. >> > Successfully bootstrapped and passed make check on >> >

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-28 Thread Richard Guenther
On Thu, 27 Oct 2011, Uros Bizjak wrote: > Hello! > > > Here's a patch for PR47698, which is about CMOV should not be > > generated for memory address marked as volatile. > > Successfully bootstrapped and passed make check on x86_64-unknown-linux-gnu. > > > PR rtl-optimization/47698 >

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-27 Thread Richard Henderson
On 10/27/2011 05:17 AM, Sergey Ostanevich wrote: > + /* MOVCC semantics implies that source is always read which is wrong > + for devices I/O that are defined using volatile in C. PR47698 */ > + > + if (MEM_P (operands[2]) && MEM_VOLATILE_P (operands[2])) > +return false; This looks to b

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-10-27 Thread Uros Bizjak
Hello! > Here's a patch for PR47698, which is about CMOV should not be > generated for memory address marked as volatile. > Successfully bootstrapped and passed make check on x86_64-unknown-linux-gnu. PR rtl-optimization/47698 * config/i386/i386.c (ix86_expand_int_movcc) prevent

[PATCH i386] PR47698 no CMOV for volatile mem

2011-10-27 Thread Sergey Ostanevich
Hi! Here's a patch for PR47698, which is about CMOV should not be generated for memory address marked as volatile. Successfully bootstrapped and passed make check on x86_64-unknown-linux-gnu. Is it Ok? regards, Sergos /gcc 2011-10-27 Sergey Ostanevich PR rtl-optimization/47698