Re: [PATCH i386: Check error_mark_node in multiversioning

2018-04-16 Thread Uros Bizjak
On Sun, Apr 15, 2018 at 12:55 PM, H.J. Lu wrote: > Since CET is applied to the whole program, it is correct to disallow > -fcf-protection=full without -mcet. But compiler shouldn't crash. > > OK for trunk? > > H.J. > > gcc/ > > PR target/85403 > * config/i386/i386.c (get_buil

Re: [PATCH i386: Check error_mark_node in multiversioning

2018-04-16 Thread Uros Bizjak
On Sun, Apr 15, 2018 at 12:55 PM, H.J. Lu wrote: > Since CET is applied to the whole program, it is correct to disallow > -fcf-protection=full without -mcet. But compiler shouldn't crash. I don't think this is correct approach. If CET appleis to the whole program, then it shouldn't be affected b

[PATCH i386: Check error_mark_node in multiversioning

2018-04-15 Thread H.J. Lu
Since CET is applied to the whole program, it is correct to disallow -fcf-protection=full without -mcet. But compiler shouldn't crash. OK for trunk? H.J. gcc/ PR target/85403 * config/i386/i386.c (get_builtin_code_for_version): Check error_mark_node. gcc/testsuite/