On 4 December 2014 at 11:21, Tobias Burnus
wrote:
> Manuel López-Ibáñez wrote:
>> It is still not clear to me if line_len is the length of the line read
>> or not, is it? If not, is there any way to actually get the length of
>> the line?
>
> Looking at the code in load_line, the line_len in
>
>
Hi Manuel,
thanks for rightfully nagging - I shouldn't do late at night reviews. Regarding:
Manuel López-Ibáñez wrote:
> It is still not clear to me if line_len is the length of the line read
> or not, is it? If not, is there any way to actually get the length of
> the line?
Looking at the code
On 4 December 2014 at 00:25, Tobias Burnus wrote:
> Manuel López-Ibáñez wrote:
>>
>> In any case, the current patch fixes these ICEs and I couldn't trigger
>> new ones. Bootstrapped and regression tested.
>> OK for Fortran?
>
>
> OK. Thanks.
It is still not clear to me if line_len is the length o
Manuel López-Ibáñez wrote:
In any case, the current patch fixes these ICEs and I couldn't trigger
new ones. Bootstrapped and regression tested.
OK for Fortran?
OK. Thanks.
* * *
BTW: The output of the code changes with the common diagnostic. For a
different test case, I get (old)
Hello Manuel, Tobias,
Manuel López-Ibáñez writes:
> This patch actually does not touch linemap but I will appreciate
> Dodji's comments about the approach.
Thanks :-)
> The problem is that in case of long lines, the column hint of 120
> might be too small, thus we do not have enough locations
On 2 December 2014 at 07:50, Tobias Burnus wrote:
> Hi Manuel,
>
> Manuel López-Ibáñez wrote:
>>
>> This patch actually does not touch linemap but I will appreciate
>> Dodji's comments about the approach. The problem is that in case of
>> long lines, the column hint of 120 might be too small, thus
Hi Manuel,
Manuel López-Ibáñez wrote:
This patch actually does not touch linemap but I will appreciate
Dodji's comments about the approach. The problem is that in case of
long lines, the column hint of 120 might be too small, thus we do not
have enough locations within one line to point to a hig
This patch actually does not touch linemap but I will appreciate
Dodji's comments about the approach. The problem is that in case of
long lines, the column hint of 120 might be too small, thus we do not
have enough locations within one line to point to a higher column
(like 132 in the testcase). Gi
