Dodji Seketeli wrote:
Manuel López-Ibáñez writes:
New version using XNEW. Bootstrapped & tested on x86_64-linux-gnu.
OK?
The diagnostics infrastructure changes are OK for me. Thanks!
And the Fortran part was already approved before. (Otherwise, take this
as another rubber stamp.)
Thanks
Manuel López-Ibáñez writes:
> New version using XNEW. Bootstrapped & tested on x86_64-linux-gnu.
>
> OK?
The diagnostics infrastructure changes are OK for me. Thanks!
Cheers,
--
Dodji
On 10 December 2014 at 13:54, Dodji Seketeli wrote:
>> /* Report the number of warnings and errors that occurred to the caller. */
>>
>> @@ -1525,11 +1625,14 @@ gfc_diagnostics_init (void)
>> {
>>diagnostic_starter (global_dc) = gfc_diagnostic_starter;
>>diagnostic_finalizer (global_dc)
Hello Manuel,
Manuel López-Ibáñez writes:
> New version of the patch. Tobias noticed several problems with the
> previous version:
>
> * Due to the use of placement-new for the buffered output_buffers
> pp_warning_buffer and pp_error_buffer, the pretty-printer destructor
> may end up trying to f
Manuel López-Ibáñez wrote:
OK, this is then the final patch. Bootstrapped and regression tested
on x86_64-linux-gnu.
OK to commit?
void
gfc_buffer_error (bool flag)
{
buffered_p = flag;
- pp_warning_buffer.flush_p = !flag;
+ buffered_p = flag;
}
Now there are two "buffered_p" …
Other
Tobias Burnus wrote:
Regarding the patch: For gfc_error_check, I think you need to set "rc"
(now: "error_raised") also when the new code is used. Otherwise, it
looks good to me.
Ignore that comment, I missed the existing "rc = true;" – however, you
still need to the change to the new variable
Le 06/12/2014 14:38, Manuel López-Ibáñez a écrit :
> * Tobias or other Fortran maintainers. The only test failing is
> gfortran.dg/do_iterator.f90 line 7. The old code gives an Error there,
> which the new one does not.
>
> /home/manuel/test1/pristine/gcc/testsuite/gfortran.dg/do_iterator.f90:7.9:
Manuel López-Ibáñez wrote:
I separated the diagnostics and fortran parts in two patches. This is a RFC to:
* Dodji: I needed to make diagnostic_action_after_output external. [...]
* Tobias or other Fortran maintainers. The only test failing is
gfortran.dg/do_iterator.f90 line 7. The old code gi
