On Sun, 28 Aug 2016, ayush goel wrote:
> > > +AUTOCONF_VERSION="2.69"
> > > +AUTOMAKE_VERSION="1.15"
> > > +ACLOCAL_VERSION="$AUTOMAKE_VERSION"
> > > +
> >
> > Is there a reason these need to be different from what the rest
> > of the toolchain uses?
>
> Not really, these were just the newer vers
-Ayush
On 22 August 2016 at 10:13:40 PM, Pedro Alves (pal...@redhat.com) wrote:
> On 08/22/2016 05:36 PM, ayush goel wrote:
> > +# The expected version number for the various auto tools we will
> > +# use after the import.
> > +AUTOCONF_VERSION="2.69"
> > +AUTOMAKE_VERSION="1.15"
> > +ACLOCAL_VERS
I noticed that libcpp/include/symtab.h includes
obstack.h and puts a struct obstack in an exported structure:
/* An identifier hash table for cpplib and the front ends. */
struct ht
{
/* Identifiers are allocated from here. */
struct obstack stack;
[...]
typedef struct ht cpp_hash_table;
[..
You appear to be including ../gnulib/config.h for both host and build.
That can't be right when host and build are different. In that case you
need to include config.h from the correct build directory in each case.
You also need to arrange for BUILD_CPPFLAGS to have the right -I options
for
On 08/22/2016 05:36 PM, ayush goel wrote:
> +# The expected version number for the various auto tools we will
> +# use after the import.
> +AUTOCONF_VERSION="2.69"
> +AUTOMAKE_VERSION="1.15"
> +ACLOCAL_VERSION="$AUTOMAKE_VERSION"
> +
Is there a reason these need to be different from what the rest
Updating the patch, contains only changes to the documentation.
PFA the patch
2016-08-22 Ayush Goel
* Makefile.def: Added gnulib as build & host library and dependency of
all-gcc on gnulib
* Makefile.in: regenerated
* configure.ac: Added gnulib as build and host library
* configure: regene
On 08/20/2016 11:22 AM, ayush goel wrote:
> So your concern seems valid, however the build process seems to pick
> the correct headers.
I tried it now and it does _not_ pick the correct headers. My concern
is definitely valid. More below.
> I did try to raise an error from the gnulib generated
Bootstrapped with multiple languages and multilib enabled for maximum coverage.
Regression tested on x86_64-apple-darwin15.5.0 and x86_64-linux
PFA the patch
2016-08-21 Ayush Goel
* Makefile.def: Added gnulib as build & host library and dependency of
all-gcc on gnulib
* Makefile.in: regener
On 20 August 2016 at 11:22, ayush goel wrote:
>>
>> We're talking about a one-line change, but this is absolutely
>> crucial and central to use of gnulib. Until this is correct,
>> any previous host-specific testing is invalid, unfortunately.
>>
>> In the previous revision, you had:
>>
>> INCGNU =
>
> We're talking about a one-line change, but this is absolutely
> crucial and central to use of gnulib. Until this is correct,
> any previous host-specific testing is invalid, unfortunately.
>
> In the previous revision, you had:
>
> INCGNU = -I../gnulib -I$(srcdir)/../gnulib/import
>
> and I was
On Tue, 16 Aug 2016, Pedro Alves wrote:
> My recollection is that those build-machine programs link with libiberty
> too today, and should thus switch to gnulib as well, right?
Yes. For host programs the include path for the $host build of gnulib
must be used, and for build programs the include
Hi there,
On 08/15/2016 01:50 PM, ayush goel wrote:
> +# Where to find the gnulib library
> +LIBGNU = ../gnulib/import/libgnu.a
> +BUILD_LIBGNU= $(build_libobjdir)/gnulib/import/libgnu.a
> +INCGNU = -I$(srcdir)/../gnulib/import
> +
I may be missing something, but I don't understand how can this
On 15 August 2016 at 13:50, ayush goel wrote:
> Included gnulib’s config.h header file inside gcc’s config.h itself as
> per the discussions.
>
> Built and tested the system.
You need to mention how you build it (languages, bootstrap, etc.) and
how you tested it (targets).
Do the other patches t
Included gnulib’s config.h header file inside gcc’s config.h itself as
per the discussions.
Built and tested the system.
PFA the patch
2016-08-14 Ayush Goel
* Makefile.def: Added gnulib as build & host library and dependency of
all-gcc on gnulib
* Makefile.in: regenerated
* configure.ac: Add
On 08/10/2016 06:51 PM, ayush goel wrote:
> On 10 August 2016 at 11:19:42 PM, Pedro Alves (pal...@redhat.com) wrote:
>> On 08/10/2016 06:33 PM, ayush goel wrote:
>>
>>> I can see mkconfig.sh being invoked inside gcc/Makefile.in with
>>> different arguments to create the gcc header files (config.h e
On 10 August 2016 at 11:19:42 PM, Pedro Alves (pal...@redhat.com) wrote:
> On 08/10/2016 06:33 PM, ayush goel wrote:
>
> > I can see mkconfig.sh being invoked inside gcc/Makefile.in with
> > different arguments to create the gcc header files (config.h etc).
> > So I guess I’ll copy all the definiti
On 08/10/2016 06:33 PM, ayush goel wrote:
> I can see mkconfig.sh being invoked inside gcc/Makefile.in with
> different arguments to create the gcc header files (config.h etc).
> So I guess I’ll copy all the definitions from gnulib/config.h inside
> mkconfig.sh and try and test the system.
What d
> # auto-host.h is the file containing items generated by autoconf and is
> # the first file included by config.h.
> # If host=build, it is correct to have bconfig include auto-host.h
> # as well. If host!=build, we are in error and need to do more
> # work to find out the build config parameters.
On 08/10/2016 05:31 PM, ayush goel wrote:
> On 10 August 2016 at 7:36:41 PM, Pedro Alves (pal...@redhat.com) wrote:
> So I was getting the exact same error as above and that is precisely
> why I included "-I../gnulib” in the include path. I figured the
> compiler wasn’t able to find config.h and h
On 10 August 2016 at 7:36:41 PM, Pedro Alves (pal...@redhat.com) wrote:
> On 08/10/2016 02:40 PM, ayush goel wrote:
> > On 9 August 2016 at 2:20:59 PM, Pedro Alves (pal...@redhat.com) wrote:
>
> > I wasn’t aware of this. Thanks for pointing this out.
> > It’s strange however, I didn’t see anything
On 08/10/2016 03:06 PM, Pedro Alves wrote:
> Since you're problably going to use sed to patch the files, including
> some new file instead of config.h should be about the same work.
Note, above I was assuming that if you include the gnulib config.h file
in system.h, then you're going to move the
On 08/10/2016 03:05 PM, Manuel López-Ibáñez wrote:
> On 10 August 2016 at 14:40, ayush goel wrote:
>> On 9 August 2016 at 2:20:59 PM, Pedro Alves (pal...@redhat.com) wrote:
>>> the scheme of configuring gnulib in a separate directory as borrowed from
>>> gdb
>>> requires including two config.h he
On 08/10/2016 02:40 PM, ayush goel wrote:
> On 9 August 2016 at 2:20:59 PM, Pedro Alves (pal...@redhat.com) wrote:
> I wasn’t aware of this. Thanks for pointing this out.
> It’s strange however, I didn’t see anything failing while
> building/testing my system.
If I comment out the include on gdb,
On 10 August 2016 at 14:40, ayush goel wrote:
> On 9 August 2016 at 2:20:59 PM, Pedro Alves (pal...@redhat.com) wrote:
>> the scheme of configuring gnulib in a separate directory as borrowed from gdb
>> requires including two config.h headers -- the gnulib client's, and gnulib's.
Isn't this also
On 9 August 2016 at 2:20:59 PM, Pedro Alves (pal...@redhat.com) wrote:
> On 08/06/2016 05:34 AM, ayush goel wrote:
> > On 5 August 2016 at 4:09:00 AM, Pedro Alves (pal...@redhat.com) wrote:
> >> On 08/02/2016 12:38 AM, Manuel López-Ibáñez wrote:
> >>>
> >>> If there is something wrong or missing, i
ayush goel writes:
> This patch https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01302.html
> is still pending review.
The build portions are OK, assuming a global maintainer has approved of
adding gnulib in general.
On 08/06/2016 05:34 AM, ayush goel wrote:
> On 5 August 2016 at 4:09:00 AM, Pedro Alves (pal...@redhat.com) wrote:
>> On 08/02/2016 12:38 AM, Manuel López-Ibáñez wrote:
>>>
>>> If there is something wrong or missing, ideally we would like to know
>>> so that Ayush can work on fixing it before the S
This patch https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01302.html
is still pending review.
-Ayush
On 5 August 2016 at 4:09:00 AM, Pedro Alves (pal...@redhat.com) wrote:
> On 08/02/2016 12:38 AM, Manuel López-Ibáñez wrote:
> >
> > If there is something wrong or missing, ideally we would like to know
> > so that Ayush can work on fixing it before the Summer of Code is over
> > in less than two we
On 08/02/2016 12:38 AM, Manuel López-Ibáñez wrote:
>
> If there is something wrong or missing, ideally we would like to know
> so that Ayush can work on fixing it before the Summer of Code is over
> in less than two weeks.
I couldn't see anywhere gnulib's config.h file is included.
gnulib's repl
On 29 July 2016 at 17:55, Manuel López-Ibáñez wrote:
> On 29 July 2016 at 17:51, Joseph Myers wrote:
>> On Wed, 20 Jul 2016, Manuel López-Ibáñez wrote:
>>
>>> On 20 July 2016 at 19:21, ayush goel wrote:
>>> > Hey,
>>> > As a first step of my GSOC project
>>> > (https://gcc.gnu.org/wiki/replaceli
On 29 July 2016 at 17:51, Joseph Myers wrote:
> On Wed, 20 Jul 2016, Manuel López-Ibáñez wrote:
>
>> On 20 July 2016 at 19:21, ayush goel wrote:
>> > Hey,
>> > As a first step of my GSOC project
>> > (https://gcc.gnu.org/wiki/replacelibibertywithgnulib) I have imported
>> > the gnulib library ins
On Wed, 20 Jul 2016, Manuel López-Ibáñez wrote:
> On 20 July 2016 at 19:21, ayush goel wrote:
> > Hey,
> > As a first step of my GSOC project
> > (https://gcc.gnu.org/wiki/replacelibibertywithgnulib) I have imported
> > the gnulib library inside the gcc tree. I have created gnulib as a top
> > le
This patch https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01302.html
is still pending review.
-Ayush
On 20 July 2016 at 19:21, ayush goel wrote:
> Hey,
> As a first step of my GSOC project
> (https://gcc.gnu.org/wiki/replacelibibertywithgnulib) I have imported
> the gnulib library inside the gcc tree. I have created gnulib as a top
> level directory which contains the necessary scripts to import
Hey,
As a first step of my GSOC project
(https://gcc.gnu.org/wiki/replacelibibertywithgnulib) I have imported
the gnulib library inside the gcc tree. I have created gnulib as a top
level directory which contains the necessary scripts to import the
modules. It also contains the necessary Makefile.in
36 matches
Mail list logo
