Re: [PATCH V7] rs6000: Optimize cmp on rotated 16bits constant

2022-12-19 Thread Jiufu Guo via Gcc-patches
Hi Segher, Thanks for your review, and helpful comments! Segher Boessenkool writes: > Hi! > > Mostlt nitpicking left: > > On Mon, Dec 19, 2022 at 10:06:45PM +0800, Jiufu Guo wrote: >> When checking eq/ne with a constant which has only 16bits, it can be >> optimized to check the rotated data.

Re: [PATCH V7] rs6000: Optimize cmp on rotated 16bits constant

2022-12-19 Thread Segher Boessenkool
Hi! Mostlt nitpicking left: On Mon, Dec 19, 2022 at 10:06:45PM +0800, Jiufu Guo wrote: > When checking eq/ne with a constant which has only 16bits, it can be > optimized to check the rotated data. By this, the constant building > is optimized. > > As the example in PR103743: > For "in == 0x8000

[PATCH V7] rs6000: Optimize cmp on rotated 16bits constant

2022-12-19 Thread Jiufu Guo via Gcc-patches
Hi, When checking eq/ne with a constant which has only 16bits, it can be optimized to check the rotated data. By this, the constant building is optimized. As the example in PR103743: For "in == 0x8000LL", this patch generates: rotldi 3,3,1 ; cmpldi 0,3,1 instead of: l