Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-10 Thread Richard Biener
On Mon, 8 Jul 2019, Kewen.Lin wrote: > Hi Richard, > > Thanks a lot for your review and reply, I've updated the patch accordingly. > > Main changes compared to previous one: > - Consider SVE (poly_int) on bit_field_ref size/offset. > - Filter valid candidates with sbitmap first. > - Suppor

Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-09 Thread Segher Boessenkool
On Tue, Jul 09, 2019 at 10:28:06AM +0800, Kewen.Lin wrote: > on 2019/7/9 上午12:32, Segher Boessenkool wrote: > > On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: > >> --- /dev/null > >> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1.c > >> @@ -0,0 +1,60 @@ > >> +/* { dg-do run } */ > >> +/*

Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-08 Thread Kewen.Lin
Hi Segher, on 2019/7/9 上午12:32, Segher Boessenkool wrote: > Hi Kewen, > > On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: >> gcc/ChangeLog > > (You have trailing spaces in the changelog, fwiw). > Thanks for catching! >> --- /dev/null >> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1

Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-08 Thread Segher Boessenkool
Hi Kewen, On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: > gcc/ChangeLog (You have trailing spaces in the changelog, fwiw). > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1.c > @@ -0,0 +1,60 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target vect_double } */

[PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-08 Thread Kewen.Lin
Hi Richard, Thanks a lot for your review and reply, I've updated the patch accordingly. Main changes compared to previous one: - Consider SVE (poly_int) on bit_field_ref size/offset. - Filter valid candidates with sbitmap first. - Support multiple modes (TODO 1). - Test cases: add SSE2 su