Re: [PATCH V4] Loop split upon semi-invariant condition (PR tree-optimization/89134)

2019-11-05 Thread Feng Xue OS
> Uh. Note it's not exactly helpful to change algorithms between > reviews, that makes it > just harder :/ > > Btw, I notice you use post-dominance info. Note that we generally do > not keep that > up-to-date with CFG manipulations (and for dominators fast queries are > disabled). > Probably the

Re: [PATCH V4] Loop split upon semi-invariant condition (PR tree-optimization/89134)

2019-11-05 Thread Richard Biener
On Thu, Oct 31, 2019 at 3:38 PM Feng Xue OS wrote: > > Hi, Richard > >This is a new patch to support more generalized semi-invariant condition, > which uses > control dependence analysis. Uh. Note it's not exactly helpful to change algorithms between reviews, that makes it just harder :/ B

[PATCH V4] Loop split upon semi-invariant condition (PR tree-optimization/89134)

2019-10-31 Thread Feng Xue OS
Hi, Richard This is a new patch to support more generalized semi-invariant condition, which uses control dependence analysis. Thanks, Feng From: Feng Xue OS Sent: Friday, October 25, 2019 11:43 AM To: Richard Biener Cc: Michael Matz; Philipp Tomsich;