Re: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread juzhe.zh...@rivai.ai
Fixed on trunk. Pl;z verify it. juzhe.zh...@rivai.ai From: Patrick O'Neill Date: 2023-10-24 09:01 To: juzhe.zh...@rivai.ai; 丁乐华 CC: kito.cheng; Robin Dapp; palmer; jeffreyalaw; gcc-patches Subject: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass IIRC --enable-checking=yes does not

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread Patrick O'Neill
ailto:rdapp@gmail.com>; palmer <mailto:pal...@rivosinc.com>; Jeff Law <mailto:jeffreya...@gmail.com>; gcc-patches <mailto:gcc-patches@gcc.gnu.org> *Subject:* Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass When configuring, pass in --enable-checking=rtl I

Re: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread juzhe.zh...@rivai.ai
atrick O'Neill Date: 2023-10-24 07:42 To: 钟居哲; 丁乐华 CC: kito.cheng; rdapp.gcc; palmer; Jeff Law; gcc-patches Subject: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass When configuring, pass in --enable-checking=rtl If you're using riscv-gnu-toolchain, pass in --enable-gcc-checking=rtl

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread Patrick O'Neill
Law <mailto:jeffreya...@gmail.com>; gcc-patches <mailto:gcc-patches@gcc.gnu.org> *Subject:* Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass You're on top of it - thanks for fixing this! I'll send the testcase. Unrelated to this failure, I'm seeing a bu

Re: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread 钟居哲
I didn't reproduce it. How to enable RTL checking ? juzhe.zh...@rivai.ai From: Patrick O'Neill Date: 2023-10-24 06:46 To: 钟居哲; 丁乐华 CC: kito.cheng; rdapp.gcc; palmer; Jeff Law; gcc-patches Subject: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass You're on top of it - th

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread Patrick O'Neill
..@rivosinc.com>; Jeff Law <mailto:jeffreya...@gmail.com>; gcc-patches <mailto:gcc-patches@gcc.gnu.org>; 钟居哲 <mailto:juzhe.zh...@rivai.ai> *Subject:* Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass Hi Lehua, This patch causes a build failure with newlib

Re: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread 钟居哲
Lehua Ding CC: kito.cheng; rdapp.gcc; palmer; Jeff Law; gcc-patches; 钟居哲 Subject: Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass Hi Lehua, This patch causes a build failure with newlib 4.1.0 with -march=rv64gv_zbb. I've creduced the failure here: https://gcc.gnu.org/bugzilla/show_

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-23 Thread Patrick O'Neill
;mailto:juzhe.zh...@rivai.ai>; kito.cheng     <mailto:kito.ch...@gmail.com>; rdapp.gcc     <mailto:rdapp@gmail.com>; palmer <mailto:pal...@rivosinc.com>;     jeffreyalaw <mailto:jeffreya...@gmail.com>; lehua.ding     <mailto:lehua.d...@rivai.ai>     *Subject:* 

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Lehua Ding
.ding <mailto:lehua.d...@rivai.ai> *Subject:* [PATCH V3 00/11] Refactor and cleanup vsetvl pass This patch refactors and cleanups the vsetvl pass in order to make the code easier to modify and understand. This patch does several things: 1. Introducing a virtual CFG for

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Lehua Ding
ya...@gmail.com>; lehua.ding <mailto:lehua.d...@rivai.ai> *Subject:* [PATCH V3 00/11] Refactor and cleanup vsetvl pass This patch refactors and cleanups the vsetvl pass in order to make the code easier to modify and understand. This patch does several things: 1. Int

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Patrick O'Neill
zhe.zh...@rivai.ai>; kito.cheng <mailto:kito.ch...@gmail.com>; rdapp.gcc <mailto:rdapp@gmail.com>; palmer <mailto:pal...@rivosinc.com>; jeffreyalaw <mailto:jeffreya...@gmail.com>; lehua.ding <mailto:lehua.d...@rivai.ai> *Subject:* [PATCH V3 00/11] Refactor a

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread 钟居哲
: juzhe.zhong; kito.cheng; rdapp.gcc; palmer; jeffreyalaw; lehua.ding Subject: [PATCH V3 00/11] Refactor and cleanup vsetvl pass This patch refactors and cleanups the vsetvl pass in order to make the code easier to modify and understand. This patch does several things: 1. Introducing a virtual CFG

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Lehua Ding
Okay, thanks anyway. On 2023/10/19 16:38, Robin Dapp wrote: Hi Lehua, thanks for the extensive rework. I'm going to let Juzhe handle the review since it's his pass and he knows it best. Delegated it to him in patchwork. Regards Robin -- Best, Lehua (RiVAI) lehua.d...@rivai.ai

Re: [PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Robin Dapp
Hi Lehua, thanks for the extensive rework. I'm going to let Juzhe handle the review since it's his pass and he knows it best. Delegated it to him in patchwork. Regards Robin

[PATCH V3 00/11] Refactor and cleanup vsetvl pass

2023-10-19 Thread Lehua Ding
This patch refactors and cleanups the vsetvl pass in order to make the code easier to modify and understand. This patch does several things: 1. Introducing a virtual CFG for vsetvl infos and Phase 1, 2 and 3 only maintain and modify this virtual CFG. Phase 4 performs insertion, modification and