Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Segher Boessenkool writes: > Hi Jiu Fu, > > On Thu, Nov 07, 2019 at 10:40:41PM +0800, Jiufu Guo wrote: >> gcc/ >> 2019-11-07 Jiufu Guo >> >> PR tree-optimization/88760 >> * gcc/config/rs6000/rs6000.opt (-munroll-only-small-loops): New option. >> * gcc/common/config/rs6000/rs600

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Hi Jiu Fu, On Thu, Nov 07, 2019 at 10:40:41PM +0800, Jiufu Guo wrote: > gcc/ > 2019-11-07 Jiufu Guo > > PR tree-optimization/88760 > * gcc/config/rs6000/rs6000.opt (-munroll-only-small-loops): New option. > * gcc/common/config/rs6000/rs6000-common.c > (rs6000_option_opt

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Jiufu Guo writes: Hi Sehger, I updated the patch as we discussed. This patch does not turn on -fweb or -frename-registers with -funroll-loops for powerpc. Thanks for review in advance. gcc/ 2019-11-07 Jiufu Guo PR tree-optimization/88760 * gcc/config/rs6000/rs6000.opt (-mu

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Jiufu Guo writes: Hi Segher, I updated the patch for option name at the end of this mail. Thanks for review in advance. > Jiufu Guo writes: > >> Segher Boessenkool writes: >> >>> Hi! >>> >>> On Tue, Nov 05, 2019 at 04:33:23PM +0800, Jiufu Guo wrote: --- gcc/common/config/rs6000/rs6000-co

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Jiufu Guo writes: > Segher Boessenkool writes: > >> Hi! >> >> On Tue, Nov 05, 2019 at 04:33:23PM +0800, Jiufu Guo wrote: >>> --- gcc/common/config/rs6000/rs6000-common.c(revision 277765) >>> +++ gcc/common/config/rs6000/rs6000-common.c(working copy) >>> @@ -35,7 +35,9 @@ static c

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Segher Boessenkool writes: > Hi! > > On Tue, Nov 05, 2019 at 04:33:23PM +0800, Jiufu Guo wrote: >> --- gcc/common/config/rs6000/rs6000-common.c (revision 277765) >> +++ gcc/common/config/rs6000/rs6000-common.c (working copy) >> @@ -35,7 +35,9 @@ static const struct default_options rs6000_option_

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Hi! On Tue, Nov 05, 2019 at 04:33:23PM +0800, Jiufu Guo wrote: > --- gcc/common/config/rs6000/rs6000-common.c (revision 277765) > +++ gcc/common/config/rs6000/rs6000-common.c (working copy) > @@ -35,7 +35,9 @@ static const struct default_options rs6000_option_ > { OPT_LEVELS_ALL, OPT_fsplit

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Jiufu Guo writes: Got message about fail to send to gcc-patches. Send again. > Segher Boessenkool writes: > >> Hi! >> >> On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: >>> In this patch, loop unroll adjust hook is introduced for powerpc. We can do >>> target related hueristic adjus

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Jiufu Guo writes: > Segher Boessenkool writes: > >> Hi! >> >> On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: >>> In this patch, loop unroll adjust hook is introduced for powerpc. We can do >>> target related hueristic adjustment in this hook. In this patch, small loops >>> is unroll

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Richard Biener writes: > On Mon, 4 Nov 2019, Segher Boessenkool wrote: > >> Hi! >> >> On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: >> > In this patch, loop unroll adjust hook is introduced for powerpc. We can >> > do >> > target related hueristic adjustment in this hook. In this

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Segher Boessenkool writes: > Hi! > > On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: >> In this patch, loop unroll adjust hook is introduced for powerpc. We can do >> target related hueristic adjustment in this hook. In this patch, small loops >> is unrolled 2 times for O2 and O3 by d

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

On Mon, 4 Nov 2019, Segher Boessenkool wrote: > Hi! > > On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: > > In this patch, loop unroll adjust hook is introduced for powerpc. We can do > > target related hueristic adjustment in this hook. In this patch, small loops > > is unrolled 2 ti

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Hi! On Mon, Nov 04, 2019 at 02:31:43PM +0800, Jiufu Guo wrote: > In this patch, loop unroll adjust hook is introduced for powerpc. We can do > target related hueristic adjustment in this hook. In this patch, small loops > is unrolled 2 times for O2 and O3 by default. With this patch, we can see

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

"Kewen.Lin" writes: > Hi Jeff, > > Thanks for the patch, I learned a lot from it. Some nits embedded. Thanks for your comments! > > on 2019/11/4 下午2:31, Jiufu Guo wrote: >> Hi, >> >> In this patch, loop unroll adjust hook is introduced for powerpc. We can do >> target related hueristic adjustm

Re: [PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Hi Jeff, Thanks for the patch, I learned a lot from it. Some nits embedded. on 2019/11/4 下午2:31, Jiufu Guo wrote: > Hi, > > In this patch, loop unroll adjust hook is introduced for powerpc. We can do > target related hueristic adjustment in this hook. In this patch, small loops > is unrolled 2

[PATCH V3] rs6000: Refine small loop unroll in loop_unroll_adjust hook

Hi, In this patch, loop unroll adjust hook is introduced for powerpc. We can do target related hueristic adjustment in this hook. In this patch, small loops is unrolled 2 times for O2 and O3 by default. With this patch, we can see some improvement for spec2017. This patch enhanced a little for