Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-09-09 Thread Michael Meissner
On Fri, Sep 06, 2019 at 07:50:51AM -0500, Segher Boessenkool wrote: > On Thu, Sep 05, 2019 at 08:18:02PM -0400, Michael Meissner wrote: > > On Thu, Aug 29, 2019 at 04:32:07PM -0500, Segher Boessenkool wrote: > > > This is not just for reload anymore, so please don't name it that. > > > Renaming >

Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-09-06 Thread Segher Boessenkool
On Thu, Sep 05, 2019 at 08:18:02PM -0400, Michael Meissner wrote: > On Thu, Aug 29, 2019 at 04:32:07PM -0500, Segher Boessenkool wrote: > > This is not just for reload anymore, so please don't name it that. Renaming > > things isn't hard, this isn't a public API or anything :-) > > This hasn't ju

Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-09-05 Thread Michael Meissner
On Thu, Aug 29, 2019 at 04:32:07PM -0500, Segher Boessenkool wrote: > This is not just for reload anymore, so please don't name it that. Renaming > things isn't hard, this isn't a public API or anything :-) This hasn't just be for reload for several years now. Do you have a name you prefer? --

Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-08-29 Thread Segher Boessenkool
On Wed, Aug 28, 2019 at 05:26:55PM -0400, Michael Meissner wrote: > On Wed, Aug 28, 2019 at 12:14:58PM -0500, Segher Boessenkool wrote: > > > +/* Enumeration giving the type of traditional addressing that would be > > > used to > > > + decide whether an instruction uses prefixed memory or not.

Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-08-28 Thread Michael Meissner
On Wed, Aug 28, 2019 at 12:14:58PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Mon, Aug 26, 2019 at 03:54:14PM -0400, Michael Meissner wrote: > > @@ -1626,8 +1626,8 @@ (define_predicate "small_toc_ref" > >return GET_CODE (op) == UNSPEC && XINT (op, 1) == UNSPEC_TOCREL; > > }) > > > >

Re: [PATCH V3, #1 of 10], Add basic pc-relative support

2019-08-28 Thread Segher Boessenkool
Hi Mike, On Mon, Aug 26, 2019 at 03:54:14PM -0400, Michael Meissner wrote: > @@ -1626,8 +1626,8 @@ (define_predicate "small_toc_ref" >return GET_CODE (op) == UNSPEC && XINT (op, 1) == UNSPEC_TOCREL; > }) > > -;; Return true if the operand is a pc-relative address. > -(define_predicate "pcre

[PATCH V3, #1 of 10], Add basic pc-relative support

2019-08-26 Thread Michael Meissner
This patch adds basic pc-relative support. I changed the public type used in the prefixed match function from insn_form to trad_form. This argument is used in matching prefixed addresses to say whether the traditional instruction's offset uses the D instruction format, the DS instruction format,