Re: [PATCH V2]rs6000: Store complicated constant into pool

Hi! On Thu, Jun 16, 2022 at 03:47:49PM +0800, Jiufu Guo wrote: > Segher Boessenkool writes: > >> >> --- a/gcc/testsuite/gcc.target/powerpc/medium_offset.c > >> >> +++ b/gcc/testsuite/gcc.target/powerpc/medium_offset.c > >> >> @@ -1,7 +1,7 @@ > >> >> /* { dg-do compile { target { powerpc*-*-* } }

Re: [PATCH V2]rs6000: Store complicated constant into pool

Segher Boessenkool writes: Hi Segher! Thanks for your comments and suggestions!! > Hi! > > On Wed, Jun 15, 2022 at 04:19:41PM +0800, Jiufu Guo wrote: >> Segher Boessenkool writes: >> > Have you tried with different limits? >> I drafted cases(C code, and updated asm code) to test runtime costs

Re: [PATCH V2]rs6000: Store complicated constant into pool

Hi! On Wed, Jun 15, 2022 at 04:19:41PM +0800, Jiufu Guo wrote: > Segher Boessenkool writes: > > Have you tried with different limits? > I drafted cases(C code, and updated asm code) to test runtime costs for > different code sequences: building constants with 5 insns; with 3 > insns and 2 insns;

Re: [PATCH V2]rs6000: Store complicated constant into pool

Segher Boessenkool writes: Hi Segher, Thanks so much for your review and sugguestions! > Hi! > > On Tue, Jun 14, 2022 at 09:23:55PM +0800, Jiufu Guo wrote: >> This patch reduces the threshold of instruction number for storing >> constant to pool and update cost for constant and mem accessing. >

Re: [PATCH V2]rs6000: Store complicated constant into pool

Hi! On Tue, Jun 14, 2022 at 09:23:55PM +0800, Jiufu Guo wrote: > This patch reduces the threshold of instruction number for storing > constant to pool and update cost for constant and mem accessing. > And then if building the constant needs more than 2 instructions (or > more than 1 instruction on

[PATCH V2]rs6000: Store complicated constant into pool

Hi, This patch is same with nearly: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595378.html The concept of this patch is similar with the patches which is attached in PR63281. e.g. https://gcc.gnu.org/bugzilla/attachment.cgi?id=42186 I had a test for perlbench from SPEC2017. As expected,

[PATCH V2]rs6000: Store complicated constant into pool

Hi, And after some discussions in the previous review: https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591509.html This patch simply updates the rtx_cost hook to accurate cost on constant by using 'COSTS_N_INSNS' with 'num_insns_constant'. This could avoid CSE eliminate constant loading.