On Fri, 2020-09-11 at 12:31 +0200, Andrea Corallo wrote:
> Hi Dave,
>
> thanks for the review!
>
> David Malcolm writes:
>
> [...]
>
> > Was there a reason for using reinterpret_cast here, rather than
> > static_cast?
>
> Yes the reason is that apparently we can't use static_cast for that:
>
Hi Dave,
thanks for the review!
David Malcolm writes:
[...]
> Was there a reason for using reinterpret_cast here, rather than
> static_cast?
Yes the reason is that apparently we can't use static_cast for that:
"error: invalid ‘static_cast’ from type ‘gcc_jit_lvalue*’ to type
‘gcc::jit::reco
On Wed, 2020-08-19 at 09:17 +0200, Andrea Corallo wrote:
> David Malcolm writes:
>
> > Thanks for the updated patch. Comments inline below.
>
> Hi Dave,
>
> sorry for the late reply.
Likewise, sorry.
[...]
> > Why the non-void return type? Looking at libgccjit.c I see it returns
> > "globa
Andrea Corallo writes:
[...]
> Sure it is, thanks for reviewing.
>
> Attached the updated version of the patch.
>
> make check-jit is clean plus I tested the new entry point with the
> modified Emacs.
>
> Thanks
>
> Andrea
Ping
David Malcolm writes:
> Thanks for the updated patch. Comments inline below.
Hi Dave,
sorry for the late reply.
> [...]
>
>> diff --git a/gcc/jit/docs/topics/expressions.rst
>> b/gcc/jit/docs/topics/expressions.rst
>> index d783ceea51a8..7699dcfd27be 100644
>> --- a/gcc/jit/docs/topics/expre
