Re: [PATCH V2] i386: Inline function with default arch/tune to caller

2023-07-05 Thread Hongyu Wang via Gcc-patches
Thanks, this is the updated patch I'm going to check in. Uros Bizjak 于2023年7月4日周二 16:57写道: > > On Tue, Jul 4, 2023 at 10:32 AM Hongyu Wang wrote: > > > > > In a follow-up patch, can you please document inlining rules involving > > > -march and -mtune to "x86 Function Attributes" section? Current

Re: [PATCH V2] i386: Inline function with default arch/tune to caller

2023-07-04 Thread Uros Bizjak via Gcc-patches
On Tue, Jul 4, 2023 at 10:32 AM Hongyu Wang wrote: > > > In a follow-up patch, can you please document inlining rules involving > > -march and -mtune to "x86 Function Attributes" section? Currently, the > > inlining rules at the end of "target function attribute" section does > > not even mention

Re: [PATCH V2] i386: Inline function with default arch/tune to caller

2023-07-04 Thread Hongyu Wang via Gcc-patches
> In a follow-up patch, can you please document inlining rules involving > -march and -mtune to "x86 Function Attributes" section? Currently, the > inlining rules at the end of "target function attribute" section does > not even mention -march and -mtune. Maybe a subsubsection "Inlining > rules" sh

Re: [PATCH V2] i386: Inline function with default arch/tune to caller

2023-07-03 Thread Uros Bizjak via Gcc-patches
On Tue, Jul 4, 2023 at 5:12 AM Hongyu Wang wrote: > > Hi, > > For function with different target attributes, current logic rejects to > inline the callee when any arch or tune is mismatched. Relax the > condition to allow callee with default arch/tune to be inlined. > > Boostrapped/regtested on x8

[PATCH V2] i386: Inline function with default arch/tune to caller

2023-07-03 Thread Hongyu Wang via Gcc-patches
Hi, For function with different target attributes, current logic rejects to inline the callee when any arch or tune is mismatched. Relax the condition to allow callee with default arch/tune to be inlined. Boostrapped/regtested on x86-64-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: *