Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-12-05 Thread Jiufu Guo via Gcc-patches
Hi, Jeff Law writes: > On 11/28/22 20:53, Jiufu Guo wrote: > >>> >>> Right, but the number of registers is target dependent, so I don't see >>> how using "8" or any number of that matter is correct here. >> I understand. And even for the same struct type, using how many >> registers to pass a p

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-12-05 Thread Jeff Law via Gcc-patches
On 11/28/22 20:53, Jiufu Guo wrote: Right, but the number of registers is target dependent, so I don't see how using "8" or any number of that matter is correct here. I understand. And even for the same struct type, using how many registers to pass a parameter, it also dependends on the si

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-28 Thread Jiufu Guo via Gcc-patches
Hi Jeff, Thanks a lot for your comments! Jeff Law writes: > On 11/22/22 19:58, Jiufu Guo wrote: >> Hi Jeff, >> >> Thanks a lot for your comments! >> >> Jeff Law writes: >> >>> On 11/20/22 20:07, Jiufu Guo wrote: Jiufu Guo writes: > Hi, > > As mentioned in the previous

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-28 Thread Jeff Law via Gcc-patches
On 11/22/22 19:58, Jiufu Guo wrote: Hi Jeff, Thanks a lot for your comments! Jeff Law writes: On 11/20/22 20:07, Jiufu Guo wrote: Jiufu Guo writes: Hi, As mentioned in the previous version patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html The suboptimal code is

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-25 Thread Jiufu Guo via Gcc-patches
Jiufu Guo via Gcc-patches writes: > Hi Richard, > > Thanks a lot for your comments! > > Richard Biener writes: > >> On Wed, 23 Nov 2022, Jiufu Guo wrote: >> >>> Hi Jeff, >>> >>> Thanks a lot for your comments! >> >> Sorry for the late response ... >> >>> Jeff Law writes: >>> >>> > On 11/20/22

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-24 Thread Jiufu Guo via Gcc-patches
Hi Richard, Thanks a lot for your comments! Richard Biener writes: > On Wed, 23 Nov 2022, Jiufu Guo wrote: > >> Hi Jeff, >> >> Thanks a lot for your comments! > > Sorry for the late response ... > >> Jeff Law writes: >> >> > On 11/20/22 20:07, Jiufu Guo wrote: >> >> Jiufu Guo writes: >> >

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-23 Thread Richard Biener via Gcc-patches
On Wed, 23 Nov 2022, Jiufu Guo wrote: > Hi Jeff, > > Thanks a lot for your comments! Sorry for the late response ... > Jeff Law writes: > > > On 11/20/22 20:07, Jiufu Guo wrote: > >> Jiufu Guo writes: > >> > >>> Hi, > >>> > >>> As mentioned in the previous version patch: > >>> https://gcc.gn

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-22 Thread Jiufu Guo via Gcc-patches
Hi Jeff, Thanks a lot for your comments! Jeff Law writes: > On 11/20/22 20:07, Jiufu Guo wrote: >> Jiufu Guo writes: >> >>> Hi, >>> >>> As mentioned in the previous version patch: >>> https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html >>> The suboptimal code is generated for "a

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/20/22 20:07, Jiufu Guo wrote: Jiufu Guo writes: Hi, As mentioned in the previous version patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html The suboptimal code is generated for "assigning from parameter" or "assigning to return value". This patch enhances the as

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-20 Thread Jiufu Guo via Gcc-patches
Jiufu Guo writes: > Hi, > > As mentioned in the previous version patch: > https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html > The suboptimal code is generated for "assigning from parameter" or > "assigning to return value". > This patch enhances the assignment from parameters lik

[PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-16 Thread Jiufu Guo via Gcc-patches
Hi, As mentioned in the previous version patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html The suboptimal code is generated for "assigning from parameter" or "assigning to return value". This patch enhances the assignment from parameters like the below cases: /case1.c t