Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-27 Thread Martin Liška
On 5/26/20 8:02 PM, Jason Merrill wrote: Maybe these environment variables should start with GCC_GIT, not just GCC, to  give more indication what they're for. All right, I renamed it and pushed to master. Martin

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-26 Thread Jason Merrill via Gcc-patches
On 5/26/20 3:12 AM, Martin Liška wrote: Hi. There's a small improvement. When filling up the ChangeLog entries, I see it handy to open a patch in a separate window. I would use GCC_DIFF_FILE env. variable for saving of the diff file. It seems easy enough to execute the command yourself in anot

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-26 Thread Martin Liška
Hi. There's a small improvement. When filling up the ChangeLog entries, I see it handy to open a patch in a separate window. I would use GCC_DIFF_FILE env. variable for saving of the diff file. Thoughts? Martin >From bffc1bdd709b5152f290febb334b009c2f225872 Mon Sep 17 00:00:00 2001 From: Martin

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Martin Liška
On 5/25/20 11:59 PM, Jason Merrill wrote: On 5/25/20 4:15 PM, Martin Liška wrote: On 5/25/20 10:08 PM, Jason Merrill wrote: Like so: I like the patch, thanks! The last question I have: Do we want to make installation of the hook optional in gcc-git-customization.sh? Sure: Thanks, I've j

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/20 4:15 PM, Martin Liška wrote: On 5/25/20 10:08 PM, Jason Merrill wrote: Like so: I like the patch, thanks! The last question I have: Do we want to make installation of the hook optional in gcc-git-customization.sh? Sure: >From 04429ee04769e15842093f154e8c7887f75d9476 Mon Sep 17 0

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Martin Liška
On 5/25/20 10:08 PM, Jason Merrill wrote: Like so: I like the patch, thanks! The last question I have: Do we want to make installation of the hook optional in gcc-git-customization.sh? Martin

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
On Mon, May 25, 2020 at 3:50 PM Jason Merrill wrote: > On Mon, May 25, 2020 at 2:14 PM Martin Liška wrote: > > > > On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: > > > This patch introduces a prepare-commit-msg hook that appends a ChangeLog > > > skeleton to a commit message that doesn

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
I'll integrate your changes with mine. On Mon, May 25, 2020 at 2:14 PM Martin Liška wrote: > > On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: > > This patch introduces a prepare-commit-msg hook that appends a ChangeLog > > skeleton to a commit message that doesn't already have one, and

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Martin Liška
On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: This patch introduces a prepare-commit-msg hook that appends a ChangeLog skeleton to a commit message that doesn't already have one, and a 'git amend-mklog' command to amend and append a new ChangeLog skeleton (to be edited together with e

[PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-23 Thread Jason Merrill via Gcc-patches
This patch introduces a prepare-commit-msg hook that appends a ChangeLog skeleton to a commit message that doesn't already have one, and a 'git amend-mklog' command to amend and append a new ChangeLog skeleton (to be edited together with existing entries by hand). Thoughts? contrib/ChangeLog: