Re: [PATCH RFC] c++: don't call 'rvalue' in coroutines code

2021-09-14 Thread Jason Merrill via Gcc-patches
On 9/14/21 11:21 AM, Iain Sandoe wrote: Hi Jason, I was looking at handling some backports to 11.x and 10.x for coroutines code-gen fixes ... On 7 May 2021, at 04:11, Jason Merrill wrote: A change to check glvalue_p rather than specifically for TARGET_EXPR revealed issues with the coroutines

Re: [PATCH RFC] c++: don't call 'rvalue' in coroutines code

2021-09-14 Thread Iain Sandoe
Hi Jason, I was looking at handling some backports to 11.x and 10.x for coroutines code-gen fixes ... > On 7 May 2021, at 04:11, Jason Merrill wrote: > > A change to check glvalue_p rather than specifically for TARGET_EXPR > revealed issues with the coroutines code's use of the 'rvalue' functio

[PATCH RFC] c++: don't call 'rvalue' in coroutines code

2021-05-06 Thread Jason Merrill via Gcc-patches
A change to check glvalue_p rather than specifically for TARGET_EXPR revealed issues with the coroutines code's use of the 'rvalue' function, which shouldn't be used on class glvalues, so I've removed those calls. In build_co_await I just dropped them, because I don't see anything in the co_await