Re: [PATCH RFC] build: enable C++11 narrowing warnings

2024-10-13 Thread Eric Gallager
On Tue, Sep 24, 2024 at 2:41 AM Richard Biener wrote: > > On Mon, Sep 23, 2024 at 3:41 PM Jason Merrill wrote: > > > > On 9/23/24 9:05 AM, Richard Biener wrote: > > > On Sat, Sep 21, 2024 at 2:49 AM Jason Merrill wrote: > > >> > > >> Tested x86_64-pc-linux-gnu. OK for trunk? > > >> > > >> -- 8<

Re: [PATCH RFC] build: enable C++11 narrowing warnings

2024-09-23 Thread Richard Biener
On Mon, Sep 23, 2024 at 3:41 PM Jason Merrill wrote: > > On 9/23/24 9:05 AM, Richard Biener wrote: > > On Sat, Sep 21, 2024 at 2:49 AM Jason Merrill wrote: > >> > >> Tested x86_64-pc-linux-gnu. OK for trunk? > >> > >> -- 8< -- > >> > >> We've been using -Wno-narrowing since gcc 4.7, but at this

Re: [PATCH RFC] build: enable C++11 narrowing warnings

2024-09-23 Thread Jason Merrill
On 9/23/24 9:05 AM, Richard Biener wrote: On Sat, Sep 21, 2024 at 2:49 AM Jason Merrill wrote: Tested x86_64-pc-linux-gnu. OK for trunk? -- 8< -- We've been using -Wno-narrowing since gcc 4.7, but at this point narrowing diagnostics seem like a stable part of C++ and we should adjust. This

Re: [PATCH RFC] build: enable C++11 narrowing warnings

2024-09-23 Thread Richard Biener
On Sat, Sep 21, 2024 at 2:49 AM Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. OK for trunk? > > -- 8< -- > > We've been using -Wno-narrowing since gcc 4.7, but at this point narrowing > diagnostics seem like a stable part of C++ and we should adjust. > > This patch changes -Wno-narrowing t

[PATCH RFC] build: enable C++11 narrowing warnings

2024-09-20 Thread Jason Merrill
Tested x86_64-pc-linux-gnu. OK for trunk? -- 8< -- We've been using -Wno-narrowing since gcc 4.7, but at this point narrowing diagnostics seem like a stable part of C++ and we should adjust. This patch changes -Wno-narrowing to -Wno-error=narrowing so that narrowing issues will still not break