Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-07 Thread Martin Liška
On 10/5/21 20:44, Jason Merrill wrote: That is the usual approach, yes.  I was giving up on that, but perhaps it's better to stick with it.  Martin, want to make that fix for save_opt_decoded_options? Yes, I'm going to install the following patch once it survives regression tests and bootstra

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-05 Thread Jason Merrill via Gcc-patches
On 10/5/21 07:27, Richard Biener wrote: On Mon, Oct 4, 2021 at 8:28 PM Jason Merrill via Gcc-patches wrote: When r12-4038 introduced the global auto_vec save_opt_decoded_options, it broke compilers configured with --enable-gather-detailed-mem-stats, due to the memory descriptors getting discar

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-05 Thread Richard Biener via Gcc-patches
On Tue, Oct 5, 2021 at 1:27 PM Richard Biener wrote: > > On Mon, Oct 4, 2021 at 8:28 PM Jason Merrill via Gcc-patches > wrote: > > > > When r12-4038 introduced the global auto_vec save_opt_decoded_options, > > it broke compilers configured with --enable-gather-detailed-mem-stats, > > due to the m

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-05 Thread Richard Biener via Gcc-patches
On Mon, Oct 4, 2021 at 8:28 PM Jason Merrill via Gcc-patches wrote: > > When r12-4038 introduced the global auto_vec save_opt_decoded_options, > it broke compilers configured with --enable-gather-detailed-mem-stats, > due to the memory descriptors getting discarded before the auto_vec was > destro

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-04 Thread Iain Sandoe
> On 4 Oct 2021, at 22:27, Jason Merrill via Gcc-patches > wrote: > > On 10/4/21 14:37, Iain Sandoe wrote: >> Hi Jason, >>> On 4 Oct 2021, at 19:27, Jason Merrill via Gcc-patches >>> wrote: >>> >>> When r12-4038 introduced the global auto_vec save_opt_decoded_options, it >>> broke compile

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-04 Thread Jason Merrill via Gcc-patches
On 10/4/21 14:37, Iain Sandoe wrote: Hi Jason, On 4 Oct 2021, at 19:27, Jason Merrill via Gcc-patches wrote: When r12-4038 introduced the global auto_vec save_opt_decoded_options, it broke compilers configured with --enable-gather-detailed-mem-stats, due to the memory descriptors getting d

Re: [PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-04 Thread Iain Sandoe
Hi Jason, > On 4 Oct 2021, at 19:27, Jason Merrill via Gcc-patches > wrote: > > When r12-4038 introduced the global auto_vec save_opt_decoded_options, it > broke compilers configured with --enable-gather-detailed-mem-stats, due to > the memory descriptors getting discarded before the auto_vec

[PATCH RFA] vec: Fix --enable-gather-detailed-mem-stats

2021-10-04 Thread Jason Merrill via Gcc-patches
When r12-4038 introduced the global auto_vec save_opt_decoded_options, it broke compilers configured with --enable-gather-detailed-mem-stats, due to the memory descriptors getting discarded before the auto_vec was destroyed. Attached below are two approaches to making this work, either by usin