Re: [PATCH RFA] input: add get_source_text_between

2022-11-04 Thread David Malcolm via Gcc-patches
On Fri, 2022-11-04 at 13:06 -0400, Jason Merrill wrote: > On 11/4/22 11:16, David Malcolm wrote: > > On Fri, 2022-11-04 at 10:27 -0400, Jason Merrill wrote: > > > On 11/3/22 19:06, David Malcolm wrote: > > > > On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc- > > > > patches > > > > wrote:

Re: [PATCH RFA] input: add get_source_text_between

2022-11-04 Thread Jason Merrill via Gcc-patches
On 11/4/22 11:16, David Malcolm wrote: On Fri, 2022-11-04 at 10:27 -0400, Jason Merrill wrote: On 11/3/22 19:06, David Malcolm wrote: On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc-patches wrote: [...snip...] Do you have test coverage for this from the DejaGnu side?  If not, you

Re: [PATCH RFA] input: add get_source_text_between

2022-11-04 Thread David Malcolm via Gcc-patches
On Fri, 2022-11-04 at 10:27 -0400, Jason Merrill wrote: > On 11/3/22 19:06, David Malcolm wrote: > > On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc-patches > > wrote: [...snip...] > > > > > > Do you have test coverage for this from the DejaGnu side?  If not, > > you > > could add self

Re: [PATCH RFA] input: add get_source_text_between

2022-11-04 Thread Jason Merrill via Gcc-patches
On 11/3/22 19:06, David Malcolm wrote: On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc-patches wrote: Tested x86_64-pc-linux-gnu, OK for trunk? -- >8 -- The c++-contracts branch uses this to retrieve the source form of the contract predicate, to be returned by contract_violation::comm

Re: [PATCH RFA] input: add get_source_text_between

2022-11-03 Thread David Malcolm via Gcc-patches
On Thu, 2022-11-03 at 15:59 -0400, Jason Merrill via Gcc-patches wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? > > -- >8 -- > > The c++-contracts branch uses this to retrieve the source form of the > contract predicate, to be returned by contract_violation::comment(). > > gcc/ChangeLog: >

[PATCH RFA] input: add get_source_text_between

2022-11-03 Thread Jason Merrill via Gcc-patches
Tested x86_64-pc-linux-gnu, OK for trunk? -- >8 -- The c++-contracts branch uses this to retrieve the source form of the contract predicate, to be returned by contract_violation::comment(). gcc/ChangeLog: * input.cc (get_source_text_between): New fn. * input.h (get_source_text_b