Re: [PATCH RFA] fold: DECL_VALUE_EXPR isn't simple [PR120400]

2025-05-27 Thread Richard Biener
On Mon, May 26, 2025 at 4:27 PM Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu, OK for trunk? LGTM. Richard. > Iain, will you verify that one of your coroutine testcases breaks without this > fix? I don't think lambda or anonymous union uses of DECL_VALUE_EXPR can > break > in the same w

Re: [PATCH RFA] fold: DECL_VALUE_EXPR isn't simple [PR120400]

2025-05-26 Thread Iain Sandoe
Hi Jason > On 26 May 2025, at 15:07, Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu, OK for trunk? > > Iain, will you verify that one of your coroutine testcases breaks without this > fix? Yes; all current coroutine ramp cleanups are exposed to (potential) UB at -O > 0. This patch reso

[PATCH RFA] fold: DECL_VALUE_EXPR isn't simple [PR120400]

2025-05-26 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, OK for trunk? Iain, will you verify that one of your coroutine testcases breaks without this fix? I don't think lambda or anonymous union uses of DECL_VALUE_EXPR can break in the same way, though this change is also correct for them. -- 8< -- This PR noted that fold_