Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-07 Thread Richard Sandiford
"Yangfei (Felix)" writes: >> > +nscalars = (STMT_SLP_TYPE (stmt_info) >> > + ? vf * DR_GROUP_SIZE (stmt_info) : vf); >> >> …the indentation on this line. Hope you don't mind, but I also “reflowed” >> the commit message to make it fit within 72 chars. >> (The

RE: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-02 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Thursday, July 2, 2020 5:17 PM > To: Yangfei (Felix) > Cc: Richard Biener ; Richard Biener > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR95961] vect: ICE: in exact_di

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-02 Thread Richard Sandiford
hes@gcc.gnu.org >> Subject: Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182 >> >> "Yangfei (Felix)" writes: >> >> On June 30, 2020 4:23:03 PM GMT+02:00, Richard Sandiford >> >> wrote: >> >> >Richard Biener writes

RE: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-02 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Wednesday, July 1, 2020 9:03 PM > To: Yangfei (Felix) > Cc: Richard Biener ; Richard Biener > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR95961] vect: ICE: in exact_di

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-01 Thread Richard Sandiford
"Yangfei (Felix)" writes: >> On June 30, 2020 4:23:03 PM GMT+02:00, Richard Sandiford >> wrote: >> >Richard Biener writes: >> >> So it seems odd to somehow put in the number of vectors... so to me >> >> it would have made sense if it did >> >> >> >> possible_npeel_number = lower_bound (nscala

RE: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-07-01 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Richard Biener [mailto:rguent...@suse.de] > Sent: Tuesday, June 30, 2020 10:50 PM > To: Richard Sandiford > Cc: Richard Biener ; Yangfei (Felix) > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR95961] vect: ICE: in exact_div, at po

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Biener
On June 30, 2020 4:23:03 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On Tue, 30 Jun 2020, Richard Sandiford wrote: >> >>> Richard Biener writes: >>> > On Tue, Jun 30, 2020 at 2:18 PM Richard Sandiford >>> > wrote: >>> >> >>> >> "Yangfei (Felix)" writes: >>> >> > diff --g

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Sandiford
Richard Biener writes: > On Tue, 30 Jun 2020, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Tue, Jun 30, 2020 at 2:18 PM Richard Sandiford >> > wrote: >> >> >> >> "Yangfei (Felix)" writes: >> >> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c >> >> > b/gcc/testsuite/gcc.d

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Biener
On Tue, 30 Jun 2020, Richard Sandiford wrote: > Richard Biener writes: > > On Tue, Jun 30, 2020 at 2:18 PM Richard Sandiford > > wrote: > >> > >> "Yangfei (Felix)" writes: > >> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > >> > b/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > >> > index

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Sandiford
Richard Biener writes: > On Tue, Jun 30, 2020 at 2:18 PM Richard Sandiford > wrote: >> >> "Yangfei (Felix)" writes: >> > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c >> > b/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c >> > index e050db1a2e4..ea39fcac0e0 100644 >> > --- a/gcc/testsuite/gcc.dg

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Biener via Gcc-patches
On Tue, Jun 30, 2020 at 2:18 PM Richard Sandiford wrote: > > "Yangfei (Felix)" writes: > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > > b/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > > index e050db1a2e4..ea39fcac0e0 100644 > > --- a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > > +++ b/gcc/

Re: [PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-30 Thread Richard Sandiford
"Yangfei (Felix)" writes: > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > b/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > index e050db1a2e4..ea39fcac0e0 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-ctor-1.c > @@ -1,6 +1,7 @@ > /* { dg-do comp

[PATCH PR95961] vect: ICE: in exact_div, at poly-int.h:2182

2020-06-29 Thread Yangfei (Felix)
Hi, PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95961 In the test case for PR95961, vectorization factor computed by vect_determine_vectorization_factor is [8,8]. But this is updated to [1,1] later by vect_update_vf_for_slp. When we call vect_get_num_vectors in vect_enhance_data_refs