Re: [PATCH PR65161]

2015-02-25 Thread Uros Bizjak
On Wed, Feb 25, 2015 at 3:24 PM, Yuri Rumyantsev wrote: > Hi All, > > Here is updated patch to fix ICE. > > Is it OK for trunk? > > 2015-02-25 Yuri Rumyantsev > > PR target/65161 > * config/i386/i386.c (ix86_sched_reorder): Skip instruction reordering > for selective scheduling. > > gcc/testsui

Re: [PATCH PR65161]

2015-02-25 Thread Yuri Rumyantsev
Hi All, Here is updated patch to fix ICE. Is it OK for trunk? 2015-02-25 Yuri Rumyantsev PR target/65161 * config/i386/i386.c (ix86_sched_reorder): Skip instruction reordering for selective scheduling. gcc/testsuite/ChangeLog * gcc.target/i386/pr65161.c: New test. 2015-02-25 17:04 GMT+03:0

Re: [PATCH PR65161]

2015-02-25 Thread Alexander Monakov
On Wed, 25 Feb 2015, Yuri Rumyantsev wrote: > I modified patch accordingly to Alexander comments. > > Is it OK for trunk? If possible, please add a short comment explaining why a shortcut is necessary, for example "HID is not populated during selective scheduling". OK for trunk from selective

Re: [PATCH PR65161]

2015-02-25 Thread Yuri Rumyantsev
I modified patch accordingly to Alexander comments. Is it OK for trunk? 2015-02-25 15:38 GMT+03:00 Alexander Monakov : > > > On Wed, 25 Feb 2015, Yuri Rumyantsev wrote: > >> Here is updated patch accordingly to Alexander comments. >> >> BTW another function using HID interface is do_reorder_for_i

Re: [PATCH PR65161]

2015-02-25 Thread Alexander Monakov
On Wed, 25 Feb 2015, Yuri Rumyantsev wrote: > Here is updated patch accordingly to Alexander comments. > > BTW another function using HID interface is do_reorder_for_imul and it > is called from ix86_sched_reorder. do_reorder_for_imul uses dependency list iteration macros, which use HDID, not

Re: [PATCH PR65161]

2015-02-25 Thread Yuri Rumyantsev
Here is updated patch accordingly to Alexander comments. BTW another function using HID interface is do_reorder_for_imul and it is called from ix86_sched_reorder. Is it OK for trunk? 2015-02-25 13:26 GMT+03:00 Alexander Monakov : > > > On Wed, 25 Feb 2015, Yuri Rumyantsev wrote: > >> Hi All, >>

Re: [PATCH PR65161]

2015-02-25 Thread Alexander Monakov
On Wed, 25 Feb 2015, Yuri Rumyantsev wrote: > Hi All, > > I prepared new patch which includes test-case. > > I can't agree with patch proposed by Alexander since other functions > doing ready list reordering also use HID interface, so I put escape > check in ix86_sched_reorder. I don't see ho

Re: [PATCH PR65161]

2015-02-25 Thread Yuri Rumyantsev
Hi All, I prepared new patch which includes test-case. I can't agree with patch proposed by Alexander since other functions doing ready list reordering also use HID interface, so I put escape check in ix86_sched_reorder. Is it OK for trunk? 2015-02-25 Yuri Rumyantsev PR target/65161 * confi

Re: [PATCH PR65161]

2015-02-24 Thread Alexander Monakov
On Tue, 24 Feb 2015, Yuri Rumyantsev wrote: > Hi All! > > Here is a simple patch to not perform instruction reordering for > selective scheduling since it uses interface of list scheduling > defined in "sched-int.h". As I see, the exact problem is that swap_top_of_ready_list accesses HID, so p

Re: [PATCH PR65161]

2015-02-24 Thread H.J. Lu
On Tue, Feb 24, 2015 at 7:10 AM, Yuri Rumyantsev wrote: > Hi All! > > Here is a simple patch to not perform instruction reordering for > selective scheduling since it uses interface of list scheduling > defined in "sched-int.h". > > Bootstrap and regression testing did not show any new failures. >

[PATCH PR65161]

2015-02-24 Thread Yuri Rumyantsev
Hi All! Here is a simple patch to not perform instruction reordering for selective scheduling since it uses interface of list scheduling defined in "sched-int.h". Bootstrap and regression testing did not show any new failures. Is it OK for trunk? ChangeLog: 2015-02-24 Yuri Rumyantsev PR tar