Re: [PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-22 Thread Eric Botcazou
> Hmm, I further revised comment in the patch since in try_combine, i2 > is always after i0/i1. The original comment is inaccurate about that. OK. -- Eric Botcazou

Re: [PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-22 Thread Eric Botcazou
> 2014-12-22 Bin Cheng > > PR rtl-optimization/62151 > * combine.c (try_combine): New local variables local_elim_i1 > and local_elim_i0. Set elim_i1 and elim_i0 using the local > version variables. Distribute notes from i0notes or i1notes > using the local variavbles. > >

Re: [PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-22 Thread Bin.Cheng
On Mon, Dec 22, 2014 at 3:54 PM, Bin.Cheng wrote: > On Sat, Dec 20, 2014 at 8:18 PM, Eric Botcazou wrote: >>> As described both in the PR and patch comments, this patch fixes PR62151 by >>> setting right value to ELIM_I0/ELIM_I1 when distributing REG_DEAD notes from >>> i0/i1. It is said that di

Re: [PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-21 Thread Bin.Cheng
On Sat, Dec 20, 2014 at 8:18 PM, Eric Botcazou wrote: >> As described both in the PR and patch comments, this patch fixes PR62151 by >> setting right value to ELIM_I0/ELIM_I1 when distributing REG_DEAD notes from >> i0/i1. It is said that distribute_notes had caused many bugs in the past. >> I th

Re: [PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-20 Thread Eric Botcazou
> As described both in the PR and patch comments, this patch fixes PR62151 by > setting right value to ELIM_I0/ELIM_I1 when distributing REG_DEAD notes from > i0/i1. It is said that distribute_notes had caused many bugs in the past. > I think it still has bug in it, as noted in the PR. This patch

[PATCH PR62151]Fix REG_DEAD note distribution issue by using right ELIM_I0/ELIM_I1

2014-12-11 Thread Bin Cheng
Hi, As described both in the PR and patch comments, this patch fixes PR62151 by setting right value to ELIM_I0/ELIM_I1 when distributing REG_DEAD notes from i0/i1. It is said that distribute_notes had caused many bugs in the past. I think it still has bug in it, as noted in the PR. This patch doe