Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-24 Thread Richard Biener
On Tue, Apr 18, 2017 at 12:39 PM, Bin Cheng wrote: > Hi, > This patch refactors interface finding invariant variables. Now customers > only need to call find_inv_vars, rather than set global variable > fd_ivopts_data > then call walk_tree. > Is it OK? Ok. RIchard. > Thanks, > bin > > 2017-04-

Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Trevor Saunders
On Tue, Apr 18, 2017 at 01:58:43PM +0100, Bin.Cheng wrote: > On Tue, Apr 18, 2017 at 1:20 PM, Trevor Saunders > wrote: > > On Tue, Apr 18, 2017 at 10:39:30AM +, Bin Cheng wrote: > >> -find_depends (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > >> +find_inv_vars_cb (tree *expr_p, int *

Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Bin.Cheng
On Tue, Apr 18, 2017 at 1:20 PM, Trevor Saunders wrote: > On Tue, Apr 18, 2017 at 10:39:30AM +, Bin Cheng wrote: >> -find_depends (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) >> +find_inv_vars_cb (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) >> { >> - bitmap *inv_vars = (bitma

Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Trevor Saunders
On Tue, Apr 18, 2017 at 10:39:30AM +, Bin Cheng wrote: > -find_depends (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > +find_inv_vars_cb (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > { > - bitmap *inv_vars = (bitmap *) data; > + struct walk_tree_data *wdata = (struct walk_tre

[PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Bin Cheng
Hi, This patch refactors interface finding invariant variables. Now customers only need to call find_inv_vars, rather than set global variable fd_ivopts_data then call walk_tree. Is it OK? Thanks, bin 2017-04-11 Bin Cheng * tree-ssa-loop-ivopts.c (struct walk_tree_data): New.