Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-19 Thread Bin.Cheng
On Tue, Jul 19, 2016 at 9:00 AM, Richard Biener wrote: > On Mon, Jul 18, 2016 at 5:36 PM, Bin.Cheng wrote: >> On Mon, Jul 18, 2016 at 4:28 PM, NightStrike wrote: >>> On Mon, Jul 18, 2016 at 3:55 AM, Bin.Cheng wrote: On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: > On Fri, Jul 15,

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-19 Thread Martin Jambor
Hi, On Mon, Jul 18, 2016 at 11:28:48AM -0400, NightStrike wrote: > Well, one thing to note is that the warning is an easy way to get a > notice of a possible missed optimization (and I have many more > occurrences of it in a particular code base that I use). If the > warning is highlighted potent

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-19 Thread Richard Biener
On Tue, Jul 19, 2016 at 10:00 AM, Richard Biener wrote: > On Mon, Jul 18, 2016 at 5:36 PM, Bin.Cheng wrote: >> On Mon, Jul 18, 2016 at 4:28 PM, NightStrike wrote: >>> On Mon, Jul 18, 2016 at 3:55 AM, Bin.Cheng wrote: On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: > On Fri, Jul 15

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-19 Thread Richard Biener
On Mon, Jul 18, 2016 at 5:36 PM, Bin.Cheng wrote: > On Mon, Jul 18, 2016 at 4:28 PM, NightStrike wrote: >> On Mon, Jul 18, 2016 at 3:55 AM, Bin.Cheng wrote: >>> On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: On Fri, Jul 15, 2016 at 1:07 PM, Bin Cheng wrote: > Hi, > This patch

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-18 Thread Bin.Cheng
On Mon, Jul 18, 2016 at 4:28 PM, NightStrike wrote: > On Mon, Jul 18, 2016 at 3:55 AM, Bin.Cheng wrote: >> On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: >>> On Fri, Jul 15, 2016 at 1:07 PM, Bin Cheng wrote: Hi, This patch removes support for -funsafe-loop-optimizations, as well

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-18 Thread NightStrike
On Mon, Jul 18, 2016 at 3:55 AM, Bin.Cheng wrote: > On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: >> On Fri, Jul 15, 2016 at 1:07 PM, Bin Cheng wrote: >>> Hi, >>> This patch removes support for -funsafe-loop-optimizations, as well as >>> -Wunsafe-loop-optimizations. By its name, this opt

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-18 Thread Bin.Cheng
On Fri, Jul 15, 2016 at 6:23 PM, Richard Biener wrote: > On July 15, 2016 7:16:42 PM GMT+02:00, Bernd Schmidt > wrote: >>On 07/15/2016 07:07 PM, Bin Cheng wrote: >> >>> Bootstrap and test on x86_64. Is it OK? >> >>If you do this you'll also need to remove the use in config/bfin. > > OK with tha

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-18 Thread Bin.Cheng
On Sat, Jul 16, 2016 at 6:28 PM, NightStrike wrote: > On Fri, Jul 15, 2016 at 1:07 PM, Bin Cheng wrote: >> Hi, >> This patch removes support for -funsafe-loop-optimizations, as well as >> -Wunsafe-loop-optimizations. By its name, this option does unsafe >> optimizations by assuming all loops m

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-16 Thread NightStrike
On Fri, Jul 15, 2016 at 1:07 PM, Bin Cheng wrote: > Hi, > This patch removes support for -funsafe-loop-optimizations, as well as > -Wunsafe-loop-optimizations. By its name, this option does unsafe > optimizations by assuming all loops must terminate and doesn't wrap. > Unfortunately, it's not

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-15 Thread Richard Biener
On July 15, 2016 7:16:42 PM GMT+02:00, Bernd Schmidt wrote: >On 07/15/2016 07:07 PM, Bin Cheng wrote: > >> Bootstrap and test on x86_64. Is it OK? > >If you do this you'll also need to remove the use in config/bfin. OK with that change. Richard. > >Bernd

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-15 Thread Bernd Schmidt
On 07/15/2016 07:07 PM, Bin Cheng wrote: Bootstrap and test on x86_64. Is it OK? If you do this you'll also need to remove the use in config/bfin. Bernd

[PATCH GCC]Remove support for -funsafe-loop-optimizations

2016-07-15 Thread Bin Cheng
Hi, This patch removes support for -funsafe-loop-optimizations, as well as -Wunsafe-loop-optimizations. By its name, this option does unsafe optimizations by assuming all loops must terminate and doesn't wrap. Unfortunately, it's not as useful as expected because: 1) Simply assuming loop must