Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On November 30, 2017 7:20:18 PM GMT+01:00, "Bin.Cheng" wrote: >On Thu, Nov 30, 2017 at 3:51 PM, Richard Biener > wrote: >> On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener >> wrote: >>> On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng >wrote: On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Bin.Cheng
On Thu, Nov 30, 2017 at 3:51 PM, Richard Biener wrote: > On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener > wrote: >> On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: >>> On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener >>> wrote: >> >> Ok, I'd like to "dumb" the pass down to the level we can so

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 4:09 PM, Richard Biener wrote: > On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: >> On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener >> wrote: >>> On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: Hi, This is updated patch with review comments resolved. Some

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 3:13 PM, Bin.Cheng wrote: > On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener > wrote: >> On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >>> Hi, >>> This is updated patch with review comments resolved. Some explanation >>> embedded below. >>> + + iloop->nb_i

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Bin.Cheng
On Thu, Nov 30, 2017 at 1:01 PM, Richard Biener wrote: > On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >> Hi, >> This is updated patch with review comments resolved. Some explanation >> embedded below. >> >>> + >>> + iloop->nb_iterations = nb_iterations; >>> >>> use std::swap? Also I thin

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Thu, Nov 30, 2017 at 2:01 PM, Richard Biener wrote: > On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: >> Hi, >> This is updated patch with review comments resolved. Some explanation >> embedded below. >> >> On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener >> wrote: >>> On Thu, Nov 16, 201

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-30 Thread Richard Biener
On Tue, Nov 28, 2017 at 4:26 PM, Bin Cheng wrote: > Hi, > This is updated patch with review comments resolved. Some explanation > embedded below. > > On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener > wrote: >> On Thu, Nov 16, 2017 at 4:18 PM, Bin.Cheng wrote: >>> On Tue, Oct 24, 2017 at 3:30

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-28 Thread Bin.Cheng
On Tue, Nov 28, 2017 at 4:00 PM, David Malcolm wrote: > On Tue, 2017-11-28 at 15:26 +, Bin Cheng wrote: >> Hi, >> This is updated patch with review comments resolved. Some >> explanation embedded below. >> >> On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener > il.com> wrote: >> > On Thu, Nov 16

Re: [PATCH GCC][V2]A simple implementation of loop interchange

2017-11-28 Thread David Malcolm
On Tue, 2017-11-28 at 15:26 +, Bin Cheng wrote: > Hi, > This is updated patch with review comments resolved. Some > explanation embedded below. > > On Mon, Nov 20, 2017 at 2:46 PM, Richard Biener il.com> wrote: > > On Thu, Nov 16, 2017 at 4:18 PM, Bin.Cheng > > wrote: > > > On Tue, Oct 24,