RE: [PING Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-11-27 Thread Bin Cheng
Message- > >> > From: gcc-patches-ow...@gcc.gnu.org > >> > [mailto:gcc-patches-ow...@gcc.gnu.org] > >> On > >> > Behalf Of Bin Cheng > >> > Sent: Tuesday, September 25, 2012 4:00 PM > >> > To: 'Richard Sandiford' &g

Re: [PING Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-11-23 Thread Ramana Radhakrishnan
, 2012 2:36 PM >> To: gcc-patches@gcc.gnu.org >> Cc: Ramana Radhakrishnan; Richard Earnshaw; 'Richard Sandiford' >> Subject: RE: [PING Updated]: [PATCH GCC/ARM] Fix problem that > hardreg_cprop >> opportunities are missed on thumb1 >> >> Ping. >> &

RE: [PING Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-10-10 Thread Bin Cheng
d' > Subject: RE: [PING Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop > opportunities are missed on thumb1 > > Ping. > > > -Original Message- > > From: gcc-patches-ow...@gcc.gnu.org > > [mailto:gcc-patches-ow...@gcc.gnu.org] > On >

RE: [PING Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-10-07 Thread Bin Cheng
es@gcc.gnu.org > Subject: RE: [Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop > opportunities are missed on thumb1 > > > > -Original Message- > > From: Richard Sandiford [mailto:rdsandif...@googlemail.com] > > Sent: Wednesday, September 05, 2012 6:0

RE: [Updated]: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-25 Thread Bin Cheng
> -Original Message- > From: Richard Sandiford [mailto:rdsandif...@googlemail.com] > Sent: Wednesday, September 05, 2012 6:09 AM > To: Bin Cheng > Cc: Ramana Radhakrishnan; 'Eric Botcazou'; gcc-patches@gcc.gnu.org > Subject: Re: Ping: [PATCH GCC/ARM] Fi

Re: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-06 Thread Richard Earnshaw
On 06/09/12 09:33, Bin Cheng wrote: >>> >>> Yes, it may be feasible to rewrite the instruction in machine reorg >>> pass, rather than peephole2. But that need bigger change in ARM back > end. >>> Hi Ramana, Richard, what's your opinion on this? >>> >>> Thanks very much. >>> >>> >> >> I side with Ri

RE: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-06 Thread Bin Cheng
> > > > Yes, it may be feasible to rewrite the instruction in machine reorg > > pass, rather than peephole2. But that need bigger change in ARM back end. > > Hi Ramana, Richard, what's your opinion on this? > > > > Thanks very much. > > > > > > I side with Richard on this one. The mid-end should

Re: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-06 Thread Richard Earnshaw
On 06/09/12 06:41, Bin Cheng wrote: > Hi Richard, > Thanks very much for comments. > >>> Ping? >>> >>> Hi Ramana, could you help me review this patch? >>> Hi Eric, Richard, could you help me review the change in regcprop.c? >> >> Subtraction of zero isn't canonical rtl though. Passes after peeph

RE: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-05 Thread Bin Cheng
Hi Richard, Thanks very much for comments. > > Ping? > > > > Hi Ramana, could you help me review this patch? > > Hi Eric, Richard, could you help me review the change in regcprop.c? > > Subtraction of zero isn't canonical rtl though. Passes after peephole2 would > be well within their rights to

Re: Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-04 Thread Richard Sandiford
"Bin Cheng" writes: >> Hi, >> For thumb1, arm-gcc rewrites move insn into subtract of ZERO in peephole2 > pass >> intentionally, then executes >> pass_if_after_reload/pass_regrename/pass_cprop_hardreg sequentially. >> >> In this scenario, copy propagation opportunities are missed because: >> 1.

Ping: [PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-09-04 Thread Bin Cheng
> Hi, > For thumb1, arm-gcc rewrites move insn into subtract of ZERO in peephole2 pass > intentionally, then executes > pass_if_after_reload/pass_regrename/pass_cprop_hardreg sequentially. > > In this scenario, copy propagation opportunities are missed because: > 1. the move insns are re-written

[PATCH GCC/ARM] Fix problem that hardreg_cprop opportunities are missed on thumb1

2012-08-13 Thread Bin Cheng
Hi, For thumb1, arm-gcc rewrites move insn into subtract of ZERO in peephole2 pass intentionally, then executes pass_if_after_reload/pass_regrename/pass_cprop_hardreg sequentially. In this scenario, copy propagation opportunities are missed because: 1. the move insns are re-written. 2. pass_cp