Re: [PATCH C++] - SD-6 Implementation Part 4 - Test suite.

2014-10-09 Thread Matthias Klose
Am 07.09.2014 um 03:48 schrieb Ed Smith-Rowland: > Greetings, > > I am finally getting back to my SD-6 C++ features test work. > > This adds front end and preprocessor tests for the language feature tests and > __has_include. > > I am still working on the fifth and last in this series to add > _

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-02 Thread Paolo Carlini
Hi, On 10/02/2014 10:08 AM, Ed Smith-Rowland wrote: On 10/02/2014 02:51 AM, Ed Smith-Rowland wrote: On 10/01/2014 11:28 AM, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h =

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-02 Thread Jonathan Wakely
On 02/10/14 02:51 -0400, Ed Smith-Rowland wrote: On 10/01/2014 11:28 AM, Jonathan Wakely wrote: Ed, the commit at http://gcc.gnu.org/r215752 doesn't have the corrections I asked for above and causes a number of test failures, could you look into it please? OK, Here is the patch. Built and t

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-02 Thread Ed Smith-Rowland
On 10/02/2014 02:51 AM, Ed Smith-Rowland wrote: On 10/01/2014 11:28 AM, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h ===

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Ed Smith-Rowland
On 10/01/2014 11:28 AM, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h === --- include/bits/stl_function.h(revision 214

Re: Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Ed Smith-Rowland
On 10/01/14, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: >On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: >>Index: include/bits/stl_function.h >>=== >>--- include/bits/stl_function.h (revision 214680)

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Jonathan Wakely
On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h === --- include/bits/stl_function.h (revision 214680) +++ include/bits/stl_function.h (working copy)

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-30 Thread Jason Merrill
On 09/29/2014 11:18 AM, Ed Smith-Rowland wrote: + /* Nonzero to prevent macro expansion. */ + unsigned char in__has_include__; I don't see anything checking this flag to prevent macro expansion. Does the comment just need a change? + /* Binary literals and variable length arrays hav

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-29 Thread Ed Smith-Rowland
On 09/25/2014 12:57 PM, Jason Merrill wrote: On 09/01/2014 09:34 PM, Ed Smith-Rowland wrote: (open_file_failed()): Not an error to not find a header file for __has_include__. Hmm, looks like this means that __has_include__ will silently return false if a header exists but is unreadabl

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-28 Thread Ed Smith-Rowland
On 09/25/2014 12:57 PM, Jason Merrill wrote: On 09/01/2014 09:34 PM, Ed Smith-Rowland wrote: (open_file_failed()): Not an error to not find a header file for __has_include__. Hmm, looks like this means that __has_include__ will silently return false if a header exists but is unreadabl

Re: [PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-26 Thread Jason Merrill
On 09/26/2014 10:20 AM, Ed Smith-Rowland wrote: On 09/25/2014 01:40 PM, Jason Merrill wrote: Don't we support attribute deprecated in C++11? We support [[gnu::deprecated]] in C++11 bit not [[deprecated]] until C++14. Hmm, that seems unnecessary. I'd allow it in C++11 as well, and *maybe* c

Re: [PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-26 Thread Ed Smith-Rowland
On 09/25/2014 01:40 PM, Jason Merrill wrote: On 09/01/2014 09:41 PM, Ed Smith-Rowland wrote: + cpp_define (pfile, "__cpp_attribute_deprecated=201309"); Don't we support attribute deprecated in C++11? Jason We support [[gnu::deprecated]] in C++11 bit not [[deprecated]] until C++14. Ed

Re: [PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-25 Thread Jason Merrill
On 09/01/2014 09:41 PM, Ed Smith-Rowland wrote: + cpp_define (pfile, "__cpp_attribute_deprecated=201309"); Don't we support attribute deprecated in C++11? Jason

Re: [PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-25 Thread Jason Merrill
On 09/01/2014 09:41 PM, Ed Smith-Rowland wrote: + /* Return type deduction was added as an extension to C++11 +and was standardized for C+14. */ + cpp_define (pfile, "__cpp_return_type_deduction=201304"); When I try to use it with -std=c++11 I get wa.C:1:8: error:

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-25 Thread Jason Merrill
On 09/01/2014 09:34 PM, Ed Smith-Rowland wrote: (open_file_failed()): Not an error to not find a header file for __has_include__. Hmm, looks like this means that __has_include__ will silently return false if a header exists but is unreadable; I would think that we want it to b

[PING 2, PATCH C++] - SD-6 Implementation Part N/4.

2014-09-25 Thread Ed Smith-Rowland
*PING* I would like review of my SD-6 implementation. Part 1 - __has_include__ built-in in libcpp. https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00083.html Part 2 - __has_include macro and C++ language feature macros. https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00084.html Part 3 - libstdc++

[PATCH C++] - SD-6 Implementation Part 4 - Test suite.

2014-09-06 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This adds front end and preprocessor tests for the language feature tests and __has_include. I am still working on the fifth and last in this series to add __had_cpp_attribute but these first four patches add a very usefu

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-09-02 Thread Jonathan Wakely
On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h === --- include/bits/stl_function.h (revision 214680) +++ include/bits/stl_function.h (working copy) @@ -217,6 +217,10 @@ }; #if __cplusplus > 2

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-01 Thread Mike Stump
On Sep 1, 2014, at 6:34 PM, Ed Smith-Rowland <3dw...@verizon.net> wrote: > (I sort of wonder why this wasn't added to the actual preprocessor 20 years > ago.) :-) So can you hack the system at template expansion time yet? :-) std::shell<“/bin/sh -c …”> maybe?

Re: [PATCH C++] - SD-6 Implementation

2014-09-01 Thread Thiago Macieira
On Monday 01 September 2014 21:58:47 Ed Smith-Rowland wrote: > The Fourth installment, testing and other oddments will be sent tomorrow. > > The implementation of __has_cpp_attribute is underway and will come in a > few days as a Fifth installment (modulo bugs this should be all). > I have it work

[PATCH C++] - SD-6 Implementation

2014-09-01 Thread Ed Smith-Rowland
The Fourth installment, testing and other oddments will be sent tomorrow. The implementation of __has_cpp_attribute is underway and will come in a few days as a Fifth installment (modulo bugs this should be all). I have it working in C++. I feel though that it would be welcome as it is in clang

[PATCH C++] - SD-6 Implementation Part 3 - .

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This adds feature macros to various libstdc++ components. The new version of SD-6 cleans up the shared_mutex noise. Some libraries that were moved to different tSen are still given macros as they are in the SD-6 draft. Bo

[PATCH C++] - SD-6 Implementation Part 2 - __has_include macro and C++ language feature macros.

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This second part adds a __has_include function-like macro that will return true if a header exists. I also added a __has_include_next function-like macro as an extension. Clang has this extension. These macros just wrap t

[PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-01 Thread Ed Smith-Rowland
Greetings, I am finally getting back to my SD-6 C++ features test work. This first part adds a __has_include__ built-in that will return true if a header exists. I also added __has_include_next__ as an extension. Clang has this extension. Both these built-ins will be wrapped in function type