Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-12-10 Thread Martin Liška
On 12/09/2014 03:15 PM, Richard Biener wrote: On Mon, Dec 8, 2014 at 5:52 PM, Martin Liška wrote: On 11/28/2014 10:32 AM, Richard Biener wrote: On Thu, Nov 27, 2014 at 6:08 PM, Martin Liška wrote: On 11/21/2014 04:21 PM, Martin Liška wrote: On 11/21/2014 04:02 PM, Richard Biener wrote:

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-12-09 Thread Richard Biener
On Mon, Dec 8, 2014 at 5:52 PM, Martin Liška wrote: > On 11/28/2014 10:32 AM, Richard Biener wrote: >> >> On Thu, Nov 27, 2014 at 6:08 PM, Martin Liška wrote: >>> >>> On 11/21/2014 04:21 PM, Martin Liška wrote: On 11/21/2014 04:02 PM, Richard Biener wrote: > > > On Fri,

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-12-08 Thread Martin Liška
On 11/28/2014 10:32 AM, Richard Biener wrote: On Thu, Nov 27, 2014 at 6:08 PM, Martin Liška wrote: On 11/21/2014 04:21 PM, Martin Liška wrote: On 11/21/2014 04:02 PM, Richard Biener wrote: On Fri, Nov 21, 2014 at 3:39 PM, Martin Liška wrote: Hello. Ok, this is simplified, one can use sr

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-28 Thread Richard Biener
On Thu, Nov 27, 2014 at 6:08 PM, Martin Liška wrote: > On 11/21/2014 04:21 PM, Martin Liška wrote: >> >> On 11/21/2014 04:02 PM, Richard Biener wrote: >>> >>> On Fri, Nov 21, 2014 at 3:39 PM, Martin Liška wrote: >>> Hello. Ok, this is simplified, one can use sreal a = 12345 and it

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-27 Thread Martin Liška
On 11/21/2014 04:21 PM, Martin Liška wrote: On 11/21/2014 04:02 PM, Richard Biener wrote: On Fri, Nov 21, 2014 at 3:39 PM, Martin Liška wrote: Hello. Ok, this is simplified, one can use sreal a = 12345 and it works ;) that's a new API, right? There is no max () and I think that using LON

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-21 Thread Martin Liška
On 11/21/2014 04:02 PM, Richard Biener wrote: On Fri, Nov 21, 2014 at 3:39 PM, Martin Liška wrote: Hello. Ok, this is simplified, one can use sreal a = 12345 and it works ;) that's a new API, right? There is no max () and I think that using LONG_MIN here is asking for trouble (host depend

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-21 Thread Richard Biener
On Fri, Nov 21, 2014 at 3:39 PM, Martin Liška wrote: > Hello. > > Ok, this is simplified, one can use sreal a = 12345 and it works ;) > >> that's a new API, right? There is no max () and I think that using >> LONG_MIN here is asking for trouble (host dependence). The >> comment in the file say

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-21 Thread Martin Liška
On 11/21/2014 01:03 PM, Richard Biener wrote: On Fri, Nov 21, 2014 at 12:21 PM, Martin Liška wrote: On 11/14/2014 11:48 AM, Richard Biener wrote: On Thu, Nov 13, 2014 at 1:35 PM, mliska wrote: gcc/ChangeLog: 2014-11-13 Martin Liska * predict.c (propagate_freq): More elegant

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-21 Thread Richard Biener
On Fri, Nov 21, 2014 at 12:21 PM, Martin Liška wrote: > On 11/14/2014 11:48 AM, Richard Biener wrote: >> >> On Thu, Nov 13, 2014 at 1:35 PM, mliska wrote: >>> >>> gcc/ChangeLog: >>> >>> 2014-11-13 Martin Liska >>> >>> * predict.c (propagate_freq): More elegant sreal API is used. >>>

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-21 Thread Martin Liška
On 11/14/2014 11:48 AM, Richard Biener wrote: On Thu, Nov 13, 2014 at 1:35 PM, mliska wrote: gcc/ChangeLog: 2014-11-13 Martin Liska * predict.c (propagate_freq): More elegant sreal API is used. (estimate_bb_frequencies): New static constants defined by sreal repl

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-14 Thread Richard Biener
On Thu, Nov 13, 2014 at 1:35 PM, mliska wrote: > gcc/ChangeLog: > > 2014-11-13 Martin Liska > > * predict.c (propagate_freq): More elegant sreal API is used. > (estimate_bb_frequencies): New static constants defined by sreal > replace precomputed ones. > * sreal.

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Trevor Saunders
On Fri, Nov 14, 2014 at 12:40:23AM +0100, Jan Hubicka wrote: > Hello, > in general I like this addition - I was not aware that sreal has no support > for negative values. > This would be serious maintainance burden if sreals was used for profile > updating - it is very > easy to get negative temp

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Jeff Law
On 11/13/14 05:35, mliska wrote: gcc/ChangeLog: 2014-11-13 Martin Liska * predict.c (propagate_freq): More elegant sreal API is used. (estimate_bb_frequencies): New static constants defined by sreal replace precomputed ones. * sreal.c (sreal::normalize): New f

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Jan Hubicka
Hello, in general I like this addition - I was not aware that sreal has no support for negative values. This would be serious maintainance burden if sreals was used for profile updating - it is very easy to get negative temporaries while dong the updates. > gcc/ChangeLog: > > 2014-11-13 Martin

[PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska * predict.c (propagate_freq): More elegant sreal API is used. (estimate_bb_frequencies): New static constants defined by sreal replace precomputed ones. * sreal.c (sreal::normalize): New function. (sreal::to_int): L