Re: [PATCH 8/9] Introduce class function_reader (v4)

2016-12-02 Thread Bernd Schmidt
On 12/01/2016 10:43 PM, David Malcolm wrote: + rtx_insn *jump_insn = get_insn_by_uid (1); + ASSERT_EQ (JUMP_INSN, GET_CODE (jump_insn)); + ASSERT_EQ (ret_rtx, JUMP_LABEL (jump_insn)); + // FIXME: ^^^ use ASSERT_RTX_PTR_EQ here ^^^ Why is this a fixme and not just done that way (several inst

Re: [PATCH 8/9] Introduce class function_reader (v4)

2016-12-01 Thread David Malcolm
On Thu, 2016-12-01 at 15:40 +0100, Bernd Schmidt wrote: Thanks for looking at this. > On 11/11/2016 10:15 PM, David Malcolm wrote: > > #include "gt-aarch64.h" > > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > > index 6c608e0..0dda786 100644 > > --- a/gcc/config/i386/i386.c > > +

Re: [PATCH 8/9] Introduce class function_reader (v4)

2016-12-01 Thread Bernd Schmidt
On 11/11/2016 10:15 PM, David Malcolm wrote: #include "gt-aarch64.h" diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 6c608e0..0dda786 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c I think we should separate out the target specific tests so as to give port

Re: [PATCH 8/9] Introduce class function_reader (v4)

2016-11-23 Thread David Malcolm
On Wed, 2016-11-23 at 21:15 +0100, Bernd Schmidt wrote: > On 11/11/2016 10:15 PM, David Malcolm wrote: > > > +static void > > +aarch64_test_loading_full_dump () > > +{ > > + rtl_dump_test t (SELFTEST_LOCATION, locate_file ("aarch64/times > > -two.rtl")); > > + > > + ASSERT_STREQ ("times_two", ID

Re: [PATCH 8/9] Introduce class function_reader (v4)

2016-11-23 Thread Bernd Schmidt
On 11/11/2016 10:15 PM, David Malcolm wrote: +static void +aarch64_test_loading_full_dump () +{ + rtl_dump_test t (SELFTEST_LOCATION, locate_file ("aarch64/times-two.rtl")); + + ASSERT_STREQ ("times_two", IDENTIFIER_POINTER (DECL_NAME (cfun->decl))); + + rtx_insn *insn_1 = get_insn_by_uid (1)

[PATCH 8/9] Introduce class function_reader (v4)

2016-11-11 Thread David Malcolm
Changed in v4: - error-handling changes split out into a separate patch - rewritten the loader to use the new "compact" dump format - support for reuse_rtx in loader - handling of params, DECL_RTL and DECL_RTL_INCOMING - moved target-dependent selftests to target-specific code (aarch64.c and i386.c