Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-27 Thread Trevor Saunders
On Tue, Oct 27, 2015 at 07:06:42PM -0600, Jeff Law wrote: > On 10/26/2015 12:45 PM, Jeff Law wrote: > Don't change the whitespace here. Looks like you probably removed a > page > break. > >>>Not obvious where it got lost as there's no filename in the review > >>>comments :-) > >> > >>Oo

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Jeff Law
On 10/26/2015 11:14 AM, Bernd Schmidt wrote: On 10/26/2015 05:59 PM, Jeff Law wrote: I left it as-is. Obviously if you really want the unnecessary braces squashed out, we can do that. It's not a rule I particularly care about myself, but I'm flagging stuff like this for the sake of consistenc

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Bernd Schmidt
On 10/26/2015 05:59 PM, Jeff Law wrote: I left it as-is. Obviously if you really want the unnecessary braces squashed out, we can do that. It's not a rule I particularly care about myself, but I'm flagging stuff like this for the sake of consistency. Don't change the whitespace here. Looks

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Jeff Law
On 10/19/2015 06:13 AM, Bernd Schmidt wrote: diff --git a/gcc/cfgcleanup.c b/gcc/cfgcleanup.c - -#ifdef ENABLE_CHECKING - verify_flow_info (); -#endif + checking_verify_flow_info (); This looks misindented. Looks that way, but it was a spaces vs tabs issue. Oh how I long

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-19 Thread Bernd Schmidt
diff --git a/gcc/cfgcleanup.c b/gcc/cfgcleanup.c - -#ifdef ENABLE_CHECKING - verify_flow_info (); -#endif + checking_verify_flow_info (); This looks misindented. -#ifdef ENABLE_CHECKING cgraph_edge *e; gcc_checking_assert ( !(e = caller->get_edg

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-18 Thread Mikhail Maltsev
On 10/06/2015 03:59 PM, Richard Biener wrote: > On Tue, Oct 6, 2015 at 2:46 PM, Bernd Schmidt wrote: >> On 10/06/2015 01:39 AM, Mikhail Maltsev wrote: >>> >>> void verify_insn_chain (void); >>> +static inline void checking_verify_insn_chain (); >>> static void fixup_fallthru_exit_predecessor (

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-06 Thread Richard Biener
On Tue, Oct 6, 2015 at 2:46 PM, Bernd Schmidt wrote: > On 10/06/2015 01:39 AM, Mikhail Maltsev wrote: >> >> void verify_insn_chain (void); >> +static inline void checking_verify_insn_chain (); >> static void fixup_fallthru_exit_predecessor (void); >> static int can_delete_note_p (const rtx_n

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-06 Thread Richard Biener
On Tue, Oct 6, 2015 at 2:46 PM, Bernd Schmidt wrote: > On 10/06/2015 01:39 AM, Mikhail Maltsev wrote: >> >> void verify_insn_chain (void); >> +static inline void checking_verify_insn_chain (); >> static void fixup_fallthru_exit_predecessor (void); >> static int can_delete_note_p (const rtx_n

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-06 Thread Bernd Schmidt
On 10/06/2015 01:39 AM, Mikhail Maltsev wrote: void verify_insn_chain (void); +static inline void checking_verify_insn_chain (); static void fixup_fallthru_exit_predecessor (void); static int can_delete_note_p (const rtx_note *); static int can_delete_label_p (const rtx_code_label *); [.

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-05 Thread Mikhail Maltsev
gcc/ChangeLog: 2015-10-05 Mikhail Maltsev * attribs.c (check_attribute_tables): Define new function. (init_attributes): Use it. * cfgcleanup.c (try_optimize_cfg): Use flag_checking. * cfgexpand.c (expand_goto, expand_debug_expr): Likewise. (pass_expand::