Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-29 Thread Jeff Law
On 05/29/14 06:07, Richard Sandiford wrote: Can't really approve it, but it looks obviously correct to me. Thanks for the fix. Is that something you'd like to see changed? Jeff

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-29 Thread Jeff Law
On 05/29/14 05:27, Tom de Vries wrote: On 10-05-14 22:24, Richard Sandiford wrote: /* A set of flags on a symbol_ref that are, in some respects, redundant with information derivable from the tree decl associated with this symbol. @@ -1791,7 +1794,9 @@ #define SYMBOL_REF_CONSTANT(RTX) \

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-29 Thread Richard Sandiford
Tom de Vries writes: > On 10-05-14 22:24, Richard Sandiford wrote: >> /* A set of flags on a symbol_ref that are, in some respects, redundant >> with >> information derivable from the tree decl associated with this symbol. >> @@ -1791,7 +1794,9 @@ #define SYMBOL_REF_CONSTANT(RTX) \ >>

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-29 Thread Tom de Vries
On 10-05-14 22:24, Richard Sandiford wrote: /* A set of flags on a symbol_ref that are, in some respects, redundant with information derivable from the tree decl associated with this symbol. @@ -1791,7 +1794,9 @@ #define SYMBOL_REF_CONSTANT(RTX) \ this information to avoid recomputing

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Jeff Law
On 05/10/14 14:24, Richard Sandiford wrote: Very much like the code to move ORIGINAL_REGNO, but with a few more knock-on changes. I handled the printing by dumping the flags immediately before the SYMBOL_REF_DATA. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * rtl

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Jeff Law
On 05/12/14 05:00, Richard Sandiford wrote: Michael Matz writes: Hi, On Sat, 10 May 2014, Richard Sandiford wrote: @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" /* The INSN_UID of an RTX_INSN-class code. */ int insn_uid; +/* The SYMBOL_REF_FLAGS of a SYMBOL_R

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Michael Matz
Hi, On Mon, 12 May 2014, Richard Sandiford wrote: > > Also I'm idly wondering if the explicit sizing of > > the fields via a bit-field as originally would be better here or just > > confusing. I guess unsigned and enums are 32bit for all hosts we care > > about, but if we ever have one where

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Richard Sandiford
Michael Matz writes: > Hi, > > On Sat, 10 May 2014, Richard Sandiford wrote: > >> @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" >> /* The INSN_UID of an RTX_INSN-class code. */ >> int insn_uid; >> >> +/* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */ >> +unsigned int

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Michael Matz
Hi, On Sat, 10 May 2014, Richard Sandiford wrote: > @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" > /* The INSN_UID of an RTX_INSN-class code. */ > int insn_uid; > > +/* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */ > +unsigned int symbol_ref_flags; > + In [3/7] y

[PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-10 Thread Richard Sandiford
Very much like the code to move ORIGINAL_REGNO, but with a few more knock-on changes. I handled the printing by dumping the flags immediately before the SYMBOL_REF_DATA. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * rtl.def (SYMBOL_REF): Remove middle "0" field.