On Wed, 11 Sep 2024, Andrew Stubbs wrote:
> On 10/09/2024 10:43, Andrew Stubbs wrote:
> > On 06/09/2024 09:47, Robin Dapp wrote:
> So we only found two instances of this problem and both were related to
> _Bools. In case you have more cases, it would be greatly appreciated
> to ver
On 10/09/2024 10:43, Andrew Stubbs wrote:
On 06/09/2024 09:47, Robin Dapp wrote:
So we only found two instances of this problem and both were related to
_Bools. In case you have more cases, it would be greatly appreciated
to verify the series with them. If you don't mind, would it be
possible
On 06/09/2024 09:47, Robin Dapp wrote:
So we only found two instances of this problem and both were related to
_Bools. In case you have more cases, it would be greatly appreciated
to verify the series with them. If you don't mind, would it be possible
to comment out the zeroing, re-run the test
> > So we only found two instances of this problem and both were related to
> > _Bools. In case you have more cases, it would be greatly appreciated
> > to verify the series with them. If you don't mind, would it be possible
> > to comment out the zeroing, re-run the testsuite and check for FAILs
On 06/09/2024 08:06, Robin Dapp wrote:
There were absolutely problems without this. It's a while ago now, so I'm
struggling with the details, but as GCC only applies the mask to selected
operations there were all sorts of issues that crept in. Zeroing the
undefined lanes seemed to match the middl
> There were absolutely problems without this. It's a while ago now, so I'm
> struggling with the details, but as GCC only applies the mask to selected
> operations there were all sorts of issues that crept in. Zeroing the
> undefined lanes seemed to match the middle end assumptions (or, at least i
On Thu, 05 Sep 2024 14:57:06 PDT (-0700), a...@baylibre.com wrote:
On Thu, 5 Sept 2024, 21:10 Robin Dapp, wrote:
> > +(define_predicate "maskload_else_operand"
> > + (and (match_code "const_int,const_vector")
> > + (match_test "op == CONST0_RTX (GET_MODE (op))")))
>
> This forces masklo
On Thu, 5 Sept 2024, 21:10 Robin Dapp, wrote:
> > > +(define_predicate "maskload_else_operand"
> > > + (and (match_code "const_int,const_vector")
> > > + (match_test "op == CONST0_RTX (GET_MODE (op))")))
> >
> > This forces maskload and mask_gather_load to only accept zero here, but
> > in
> > +(define_predicate "maskload_else_operand"
> > + (and (match_code "const_int,const_vector")
> > + (match_test "op == CONST0_RTX (GET_MODE (op))")))
>
> This forces maskload and mask_gather_load to only accept zero here, but
> in fact the hardware would allow us to accept any value (incl
(Sorry, I missed this because I was on vacation.)
On 11/08/2024 22:00, Robin Dapp wrote:
This patch adds a zero else operand to the masked loads.
The patch is OK, but I have a question below.
gcc/ChangeLog:
* config/gcn/predicates.md (maskload_else_operand): New
predicate.
On 8/11/24 3:00 PM, Robin Dapp wrote:
This patch adds a zero else operand to the masked loads.
gcc/ChangeLog:
* config/gcn/predicates.md (maskload_else_operand): New
predicate.
* config/gcn/gcn-valu.md: Use new predicate.
OK if the GCN maintainers don't chime in by th
This patch adds a zero else operand to the masked loads.
gcc/ChangeLog:
* config/gcn/predicates.md (maskload_else_operand): New
predicate.
* config/gcn/gcn-valu.md: Use new predicate.
---
gcc/config/gcn/gcn-valu.md | 6 --
gcc/config/gcn/predicates.md | 3 +++
2 fil
12 matches
Mail list logo
