Re: [PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-28 Thread Alan Modra
On Wed, Nov 28, 2018 at 07:32:50AM -0600, Segher Boessenkool wrote: > On Wed, Nov 28, 2018 at 11:37:42AM +1030, Alan Modra wrote: > > On Tue, Nov 27, 2018 at 10:29:29AM -0600, Segher Boessenkool wrote: > > > Looks fine. Thank you for the cleanup! Okay for trunk, but please do the > > > extra test

Re: [PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-28 Thread Alan Modra
On Wed, Nov 28, 2018 at 07:32:50AM -0600, Segher Boessenkool wrote: > On Wed, Nov 28, 2018 at 11:37:42AM +1030, Alan Modra wrote: > > On Tue, Nov 27, 2018 at 10:29:29AM -0600, Segher Boessenkool wrote: > > > Do you think we should to deprecate -mtls-markers in GCC 9? > > > > Support for the TLS ma

Re: [PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-28 Thread Segher Boessenkool
On Wed, Nov 28, 2018 at 11:37:42AM +1030, Alan Modra wrote: > On Tue, Nov 27, 2018 at 10:29:29AM -0600, Segher Boessenkool wrote: > > Hi! > > Thanks for the review! > > > > +(define_insn "*tls_gdld_aix" > > > + [(match_parallel 3 "" > > > > A match_parallel without predicate... Does this work?

Re: [PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-27 Thread Alan Modra
On Tue, Nov 27, 2018 at 10:29:29AM -0600, Segher Boessenkool wrote: > Hi! Thanks for the review! > > +(define_insn "*tls_gdld_aix" > > + [(match_parallel 3 "" > > A match_parallel without predicate... Does this work?! Yes. In fact, rs6000/predicates.md any_parallel_operand is useless except

Re: [PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-27 Thread Segher Boessenkool
Hi! On Tue, Nov 13, 2018 at 11:22:43PM +1030, Alan Modra wrote: > Version 2. > > The current code handling __tls_get_addr calls for powerpc*-linux > generates a call then overwrites the call insn with a special > tls_{gd,ld}_{aix,sysv} pattern. It's done that way to support > !TARGET_TLS_MARKERS

[PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-13 Thread Alan Modra
Version 2. The current code handling __tls_get_addr calls for powerpc*-linux generates a call then overwrites the call insn with a special tls_{gd,ld}_{aix,sysv} pattern. It's done that way to support !TARGET_TLS_MARKERS, where the arg setup insns need to be emitted immediately before the branch

[PATCH 5/6] [RS6000] Use standard call patterns for __tls_get_addr calls

2018-11-06 Thread Alan Modra
The current code handling __tls_get_addr calls for powerpc*-linux generates a call then overwrites the call insn with a special tls_{gd,ld}_{aix,sysv} pattern. It's done that way to support !TARGET_TLS_MARKERS, where the arg setup insns need to be emitted immediately before the branch and link. W