Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-12-16 Thread Thomas Schwinge
Hi Andrew! On 2019-11-12T13:29:13+, Andrew Stubbs wrote: > Most of these changes are simply based on the model already defined for > NVPTX, adapted for GCN as appropriate. > --- a/libgomp/openacc.f90 > +++ b/libgomp/openacc.f90 > @@ -46,6 +46,7 @@ module openacc_kinds >! integer (acc_dev

Re: "gcn" vs. "amdgcn" etc. (was: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port)

2019-12-03 Thread Julian Brown
On Tue, 3 Dec 2019 15:06:48 +0100 Thomas Schwinge wrote: > We probably can't/shouldn't change 'amdgcn' in the target triplet now, > but as far as I'm concerned, it's not too late to change > 'gcc/config/gcn' etc., but I guess that won't happen: too much > effort. (And then, I don't feel too stro

Re: Which OpenACC 'acc_device_t' to use for AMD GPU offloading (was: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port)

2019-12-03 Thread Julian Brown
On Tue, 3 Dec 2019 10:32:57 +0100 Thomas Schwinge wrote: > Hi! > > On 2019-12-02T14:50:42+, Julian Brown > wrote: > > On Mon, 2 Dec 2019 15:43:29 +0100 > > Thomas Schwinge wrote: > > > >> > --- a/libgomp/openacc.h > >> > +++ b/libgomp/openacc.h > >> > @@ -55,6 +55,7 @@ typedef enum acc_d

"gcn" vs. "amdgcn" etc. (was: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port)

2019-12-03 Thread Thomas Schwinge
Hi! On 2019-12-03T13:13:33+, Andrew Stubbs wrote: > On 02/12/2019 14:43, Thomas Schwinge wrote: >> On 2019-11-12T13:29:13+, Andrew Stubbs wrote: >>> --- a/include/gomp-constants.h >>> +++ b/include/gomp-constants.h >>> @@ -174,6 +174,7 @@ enum gomp_map_kind >>> #define GOMP_DEVICE_NVID

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-12-03 Thread Andrew Stubbs
On 02/12/2019 14:43, Thomas Schwinge wrote: Hi! On 2019-11-12T13:29:13+, Andrew Stubbs wrote: --- a/include/gomp-constants.h +++ b/include/gomp-constants.h @@ -174,6 +174,7 @@ enum gomp_map_kind #define GOMP_DEVICE_NVIDIA_PTX5 #define GOMP_DEVICE_INTEL_MIC 6 #

Which OpenACC 'acc_device_t' to use for AMD GPU offloading (was: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port)

2019-12-03 Thread Thomas Schwinge
Hi! On 2019-12-02T14:50:42+, Julian Brown wrote: > On Mon, 2 Dec 2019 15:43:29 +0100 > Thomas Schwinge wrote: > >> > --- a/libgomp/openacc.h >> > +++ b/libgomp/openacc.h >> > @@ -55,6 +55,7 @@ typedef enum acc_device_t { >> >/* acc_device_host_nonshm = 3 removed. */ >> >acc_device_n

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-12-02 Thread Julian Brown
On Mon, 2 Dec 2019 15:43:29 +0100 Thomas Schwinge wrote: > > --- a/libgomp/openacc.h > > +++ b/libgomp/openacc.h > > @@ -55,6 +55,7 @@ typedef enum acc_device_t { > >/* acc_device_host_nonshm = 3 removed. */ > >acc_device_not_host = 4, > >acc_device_nvidia = 5, > > + acc_device_gcn

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-12-02 Thread Thomas Schwinge
Hi! On 2019-11-12T13:29:13+, Andrew Stubbs wrote: > --- a/include/gomp-constants.h > +++ b/include/gomp-constants.h > @@ -174,6 +174,7 @@ enum gomp_map_kind > #define GOMP_DEVICE_NVIDIA_PTX 5 > #define GOMP_DEVICE_INTEL_MIC6 > #define GOMP_DEVICE_HSA

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-11-12 Thread Andrew Stubbs
On 12/11/2019 13:46, Jakub Jelinek wrote: On Tue, Nov 12, 2019 at 01:29:13PM +, Andrew Stubbs wrote: 2019-11-12 Andrew Stubbs include/ * gomp-constants.h (GOMP_DEVICE_GCN): Define. (GOMP_VERSION_GCN): Define. Perhaps this could be 0, but not a big deal. OG9 us

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-11-12 Thread Jakub Jelinek
On Tue, Nov 12, 2019 at 01:29:13PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > include/ > * gomp-constants.h (GOMP_DEVICE_GCN): Define. > (GOMP_VERSION_GCN): Define. Perhaps this could be 0, but not a big deal. > libgomp/ > * Makefile.am (libgomp_l

[PATCH 4/7 libgomp,amdgcn] GCN libgomp port

2019-11-12 Thread Andrew Stubbs
This patch contributes a libgomp implementation for AMD GCN, minus the plugin which is later in this series. GCN has been allocated ID number "8", even though devices "6" and "7" are no longer present in every place where the IDs exist (they were HSA and Intel MIC). Most of these changes are simp