Re: [PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes (revised, v2)

2018-12-13 Thread Jakub Jelinek
On Tue, Dec 11, 2018 at 09:47:10PM +0800, Chung-Lin Tang wrote: > I have revised the patch to make both gomp_[un]map_vars and > gomp_[un]map_vars_async > point to gomp_[un]map_vars_internal, which is static always_inline. This > should > alleviate that part of the concerns. > @@ -263,8 +279,9 @@

Re: [PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes (revised, v2)

2018-12-11 Thread Chung-Lin Tang
On 2018/12/7 1:43 AM, Jakub Jelinek wrote: On Thu, Dec 06, 2018 at 06:21:16PM +0100, Thomas Schwinge wrote: On Tue, 25 Sep 2018 21:11:24 +0800, Chung-Lin Tang wrote: Hi Jakub, This part has changes to 'struct goacc_asyncqueue*' arguments to various memory copying/mapping functions. To lessen

Re: [PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes

2018-12-06 Thread Jakub Jelinek
On Thu, Dec 06, 2018 at 06:21:16PM +0100, Thomas Schwinge wrote: > On Tue, 25 Sep 2018 21:11:24 +0800, Chung-Lin Tang > wrote: > > Hi Jakub, > > This part has changes to 'struct goacc_asyncqueue*' arguments to various > > memory copying/mapping functions. To lessen the amount of code changes new

Re: [PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes

2018-12-06 Thread Thomas Schwinge
Hi Jakub! On Tue, 25 Sep 2018 21:11:24 +0800, Chung-Lin Tang wrote: > Hi Jakub, > This part has changes to 'struct goacc_asyncqueue*' arguments to various > memory copying/mapping functions. To lessen the amount of code changes new > 'gomp_map/unmap_vars_async' > functions names are used (with

[PATCH 4/6, OpenACC, libgomp] Async re-work, libgomp/target.c changes

2018-09-25 Thread Chung-Lin Tang
Hi Jakub, This part has changes to 'struct goacc_asyncqueue*' arguments to various memory copying/mapping functions. To lessen the amount of code changes new 'gomp_map/unmap_vars_async' functions names are used (with the non-async original names defined with the asyncqueue==NULL). Inside gomp_t