Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-23 Thread Cary Coutant
> You said OK for Julian's patch in the last mail, so I'll take that as > approved (for an interim solution). If you don't mind, I'll add a TODO > to the comments (attached patch). Looks good, thanks! -cary

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-23 Thread Chung-Lin Tang
On 2013/4/23 01:35 AM, Cary Coutant wrote: >> A : host_integerp (value, TYPE_UNSIGNED (TREE_TYPE (value))) >> B : host_integerp (value, 0) >> >> AB AB AB AB >> type_size,hwi | 00 01 10 11 >> --+--- >> 32,32

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Cary Coutant
> We should really be emitting unsigned constants using add_AT_unsigned: > > if (TYPE_UNSIGNED (TREE_TYPE (value))) > { > if (host_integerp (value, 1)) > add_AT_unsigned (enum_die, DW_AT_const_value, TREE_INT_CST_LOW > (value)); > else > add_AT_unsigned_double (en

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Cary Coutant
> A : host_integerp (value, TYPE_UNSIGNED (TREE_TYPE (value))) > B : host_integerp (value, 0) > > AB AB AB AB > type_size,hwi | 00 01 10 11 > --+--- > 32,32 | X X int int > 64,32 |

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Julian Brown
On Mon, 22 Apr 2013 21:36:38 +0800 Chung-Lin Tang wrote: > On 2013/4/19 12:56 AM, Cary Coutant wrote: > > On Thu, Apr 18, 2013 at 6:49 AM, Chung-Lin Tang > > wrote: > >> This patch was a fix by Julian which corrected a > >> HOST_BITS_PER_WIDE_INT host dependency in dwarf generation. Nios > >> II

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Chung-Lin Tang
On 2013/4/19 12:56 AM, Cary Coutant wrote: > On Thu, Apr 18, 2013 at 6:49 AM, Chung-Lin Tang > wrote: >> This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT >> host dependency in dwarf generation. Nios II does not have >> need_64bit_hwint switched on during configuring, and ra

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-18 Thread Cary Coutant
On Thu, Apr 18, 2013 at 6:49 AM, Chung-Lin Tang wrote: > This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT > host dependency in dwarf generation. Nios II does not have > need_64bit_hwint switched on during configuring, and ran into GDB test > FAILs originating from this probl

[PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-18 Thread Chung-Lin Tang
This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT host dependency in dwarf generation. Nios II does not have need_64bit_hwint switched on during configuring, and ran into GDB test FAILs originating from this problem. 2013-04-18 Julian Brown * dwarf2out.c (gen_enum