Re: [PATCH 4/5][libbacktrace] Simplify memory management in build_address_map

2018-12-27 Thread Ian Lance Taylor via gcc-patches
On Wed, Nov 28, 2018 at 3:17 PM Tom de Vries wrote: > > In the main loop in build_address_map, we first read the abbrevs into a local > variable abbrevs, and then allocate the corresponding unit, after which we > assign > the abbrevs to the unit. This results in dedicated free-upon-failure > han

[PATCH 4/5][libbacktrace] Simplify memory management in build_address_map

2018-11-28 Thread Tom de Vries
Hi, In the main loop in build_address_map, we first read the abbrevs into a local variable abbrevs, and then allocate the corresponding unit, after which we assign the abbrevs to the unit. This results in dedicated free-upon-failure handling for the variable, and extra code to make sure that fre