Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-10 Thread Ilya Verbin
On 10 Dec 09:22, Jakub Jelinek wrote: > On Tue, Dec 09, 2014 at 03:32:33PM +0300, Ilya Verbin wrote: > > However, I don't see -flto option in the build log. It seems that > > check_effective_target_lto isn't working inside libgomp/ directory. > > Maybe because ENABLE_LTO is defined only in gcc/con

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-10 Thread Jakub Jelinek
On Tue, Dec 09, 2014 at 03:32:33PM +0300, Ilya Verbin wrote: > On 04 Dec 20:52, Jakub Jelinek wrote: > > On Thu, Dec 04, 2014 at 10:35:19PM +0300, Ilya Verbin wrote: > > > This issue can be resolved by forcing output of such variables. > > > Is this fix ok? Should I add a testcase? > > > > Yes, w

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-09 Thread Ilya Verbin
On 04 Dec 20:52, Jakub Jelinek wrote: > On Thu, Dec 04, 2014 at 10:35:19PM +0300, Ilya Verbin wrote: > > This issue can be resolved by forcing output of such variables. > > Is this fix ok? Should I add a testcase? > > Yes, with proper ChangeLog. Yes. Here is updated patch, ok to commit? Howeve

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-08 Thread Jakub Jelinek
On Mon, Dec 08, 2014 at 01:28:10PM +0400, Ilya Verbin wrote: > 2014-12-08 12:18 GMT+03:00 Richard Biener : > > On Thu, Dec 4, 2014 at 8:35 PM, Ilya Verbin wrote: > >> Hi, > >> > >> On 30 Sep 18:53, Ilya Verbin wrote: > >>> This patch creates 2 vectors with decls: offload_funcs and offload_vars. >

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-08 Thread Ilya Verbin
2014-12-08 12:18 GMT+03:00 Richard Biener : > On Thu, Dec 4, 2014 at 8:35 PM, Ilya Verbin wrote: >> Hi, >> >> On 30 Sep 18:53, Ilya Verbin wrote: >>> This patch creates 2 vectors with decls: offload_funcs and offload_vars. >>> libgomp will use addresses from these arrays to look up offloaded code.

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-08 Thread Richard Biener
On Thu, Dec 4, 2014 at 8:35 PM, Ilya Verbin wrote: > Hi, > > On 30 Sep 18:53, Ilya Verbin wrote: >> This patch creates 2 vectors with decls: offload_funcs and offload_vars. >> libgomp will use addresses from these arrays to look up offloaded code. >> >> During the compilation they are outputted to

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-04 Thread Jakub Jelinek
On Thu, Dec 04, 2014 at 10:35:19PM +0300, Ilya Verbin wrote: > This issue can be resolved by forcing output of such variables. > Is this fix ok? Should I add a testcase? Yes, with proper ChangeLog. Yes. > diff --git a/gcc/varpool.c b/gcc/varpool.c > index 0526b7f..db28c2a 100644 > --- a/gcc/var

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-04 Thread Ilya Verbin
Hi, On 30 Sep 18:53, Ilya Verbin wrote: > This patch creates 2 vectors with decls: offload_funcs and offload_vars. > libgomp will use addresses from these arrays to look up offloaded code. > > During the compilation they are outputted to: > * binary __gnu_offload_funcs/vars sections, or using >

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-11-12 Thread Richard Biener
On Wed, 5 Nov 2014, Ilya Verbin wrote: > On 08 Oct 11:23, Jakub Jelinek wrote: > > LGTM, with the requested var/section renames. > > Would like if Honza and/or Richard had a look at the cgraph/LTO stuff > > in the patch though. > > Since patch 2 was updated, this patch also should be updated. > N

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-11-05 Thread Ilya Verbin
On 08 Oct 11:23, Jakub Jelinek wrote: > LGTM, with the requested var/section renames. > Would like if Honza and/or Richard had a look at the cgraph/LTO stuff > in the patch though. Since patch 2 was updated, this patch also should be updated. Now the offload_vars array is filled in varpool_node::g

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-10-29 Thread Kirill Yukhin
Hello Richard, Jan, On 08 Oct 11:23, Jakub Jelinek wrote: > On Tue, Sep 30, 2014 at 06:53:20PM +0400, Ilya Verbin wrote: > > Bootstrapped and regtested on top of patch 2. Is it OK for trunk? > > LGTM, with the requested var/section renames. > Would like if Honza and/or Richard had a look at the c

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-10-08 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 06:53:20PM +0400, Ilya Verbin wrote: > Bootstrapped and regtested on top of patch 2. Is it OK for trunk? LGTM, with the requested var/section renames. Would like if Honza and/or Richard had a look at the cgraph/LTO stuff in the patch though. Jakub

[PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-09-30 Thread Ilya Verbin
Hello, This patch creates 2 vectors with decls: offload_funcs and offload_vars. libgomp will use addresses from these arrays to look up offloaded code. During the compilation they are outputted to: * .gnu.offload_lto_offload_table section as IR for offload compiler; * .gnu.lto_offload_table secti