Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Dodji Seketeli
Dodji Seketeli writes: > David Edelsohn writes: > >> Your patch broke bootstrap on AIX because of the typedef "loc_t" >> introduced in tree-diagnostics.c. I have committed the patch below. Tested on x86_64-unknown-linux-gnu only, unfortunately. I hope it fixes the build on AIX. From: Dodji S

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Dodji Seketeli
David Edelsohn writes: > Your patch broke bootstrap on AIX because of the typedef "loc_t" > introduced in tree-diagnostics.c. The typedef conflicts with a > typedef in an AIX 5.3 header file for locales. AIX should not be > using that namespace, but the failure occurs before fix-includes, so >

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Gabriel Dos Reis
On Tue, Oct 18, 2011 at 10:19 AM, Joseph S. Myers wrote: > On Tue, 18 Oct 2011, David Edelsohn wrote: > >> Hey, Dodji, >> >> Your patch broke bootstrap on AIX because of the typedef "loc_t" >> introduced in tree-diagnostics.c.  The typedef conflicts with a >> typedef in an AIX 5.3 header file for

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Jakub Jelinek
On Tue, Oct 18, 2011 at 11:09:04AM -0400, David Edelsohn wrote: > Your patch broke bootstrap on AIX because of the typedef "loc_t" > introduced in tree-diagnostics.c. The typedef conflicts with a > typedef in an AIX 5.3 header file for locales. AIX should not be > using that namespace, but the fa

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Joseph S. Myers
On Tue, 18 Oct 2011, David Edelsohn wrote: > Hey, Dodji, > > Your patch broke bootstrap on AIX because of the typedef "loc_t" > introduced in tree-diagnostics.c. The typedef conflicts with a > typedef in an AIX 5.3 header file for locales. AIX should not be > using that namespace, but the failu

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread David Edelsohn
Hey, Dodji, Your patch broke bootstrap on AIX because of the typedef "loc_t" introduced in tree-diagnostics.c. The typedef conflicts with a typedef in an AIX 5.3 header file for locales. AIX should not be using that namespace, but the failure occurs before fix-includes, so it is not possible to

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-18 Thread Dodji Seketeli
Jason Merrill writes: > If you have a patch like this that fixes a major regression, go ahead > and check it in without waiting for approval; we can adjust it as > necessary after build is working again. OK. >> size_t num_expanded_macros; > >> - fprintf (stderr, "Number of expanded macros:

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Jason Merrill
On 10/17/2011 06:33 PM, Dodji Seketeli wrote: OK if this appears to fix the raised issues and passes bootstraps on the i686 target? If you have a patch like this that fixes a major regression, go ahead and check it in without waiting for approval; we can adjust it as necessary after build is

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Dodji Seketeli
"H.J. Lu" writes: > There are at least 2 bootstrap problems: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50760 The patch below should address those issues. The first two hunks are to fix bootstrap for targets that have !NO_IMPLICIT_EXTERN_C. To test it, I built the compiler with --target=a

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread H.J. Lu
On Mon, Oct 17, 2011 at 6:41 AM, Dodji Seketeli wrote: > Finally here is what I am checking in, which passes bootstrap with > --disable-checking --enable-languages=all,ada -- modulo this other bug > that breaks bootstrap as well > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50709. > > It's been OK

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Dodji Seketeli
Finally here is what I am checking in, which passes bootstrap with --disable-checking --enable-languages=all,ada -- modulo this other bug that breaks bootstrap as well http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50709. It's been OKed off-line by Tom Tromey. commit c1cd2be336ceec75cf40ac5f32cc4f72

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Dodji Seketeli
Richard Guenther writes: > This broke bootstrap on x86_64-linux. > > /space/rguenther/src/svn/trunk/libcpp/line-map.c: In function > 'source_location linemap_macro_map_loc_to_exp_point(const line_map*, > source_location)': > /space/rguenther/src/svn/trunk/libcpp/line-map.c:628:12: error: > variab

Re: [PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Richard Guenther
On Mon, Oct 17, 2011 at 11:57 AM, Dodji Seketeli wrote: > In this third instalment the diagnostic machinery -- when faced with > the virtual location of a token resulting from macro expansion -- uses > the new linemap APIs to unwind the stack of macro expansions that led > to that token and emits

[PATCH 3/6] Emit macro expansion related diagnostics

2011-10-17 Thread Dodji Seketeli
In this third instalment the diagnostic machinery -- when faced with the virtual location of a token resulting from macro expansion -- uses the new linemap APIs to unwind the stack of macro expansions that led to that token and emits a [hopefully] more useful message than what we have today. diagn