On Wed, Nov 11, 2015 at 05:56:15PM +0300, Aleksander Ivanyushenko wrote:
> diff --git a/configure.ac b/configure.ac
> index 9241261..b997646 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -494,6 +494,18 @@ else
> fi])
> AC_SUBST(extra_liboffloadmic_configure_flags)
>
> +# Intelmic and in
On Wed, Nov 11, 2015 at 17:56:15 +0300, Aleksander Ivanyushenko wrote:
> On Mon, Aug 24, 2015 at 10:45:03 +0200, Jakub Jelinek wrote:
> > On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote:
> > > Applied the idea with python script alternative. Review, please.
> >
> > > 2015-07-28 M
On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote:
> Applied the idea with python script alternative. Review, please.
> 2015-07-28 Maxim Blumenthal
>
> * configure.ac: Add a check for xxd or python presence when the target
> is intelmic or intelmicemul.
> * con
Review the patches in the previous letter, please.
2015-08-06 17:34 GMT+03:00 Maxim Blumental :
> Applied the idea with python script alternative. Review, please.
--
-
Sincerely yours,
Maxim Blumental
Applied the idea with python script alternative. Review, please.
2015-07-28 Maxim Blumenthal
* configure.ac: Add a check for xxd or python presence when the target
is intelmic or intelmicemul.
* configure: Regenerate.
* liboffloadmic/plugin/Makefile.am: Add a co
On Mon, 2015-08-03 at 13:23 +0300, Maxim Blumental wrote:
> Could you probably review the patch, please?
Sorry, I'm not the best person to review the patch: Jakub CCed me for my
knowledge of python, so I ported his script to work with both python 2
and 3, and it ought to work with early python 2 v
Could you probably review the patch, please?
2015-07-28 18:42 GMT+03:00 Maxim Blumental :
> Applied the idea with python script alternative. Review, please.
>
> 2015-07-24 17:18 GMT+03:00 David Malcolm :
>> On Fri, 2015-07-24 at 10:01 +0200, Jakub Jelinek wrote:
>>> #!/usr/bin/python
>>> import s
Applied the idea with python script alternative. Review, please.
2015-07-24 17:18 GMT+03:00 David Malcolm :
> On Fri, 2015-07-24 at 10:01 +0200, Jakub Jelinek wrote:
>> #!/usr/bin/python
>> import sys
>> with open(sys.argv[1],"rb") as f:
>> nextblock = f.read(12)
>> while 1:
>> bl
On Fri, 2015-07-24 at 10:01 +0200, Jakub Jelinek wrote:
> #!/usr/bin/python
> import sys
> with open(sys.argv[1],"rb") as f:
> nextblock = f.read(12)
> while 1:
> block = nextblock
> nextblock = f.read(12)
> if block == "":
> break
> str = ""
>
On Thu, Jul 23, 2015 at 09:50:55PM +0300, Ilya Verbin wrote:
> > Here, I note that the xxd tool is being used, which in my distribution is
> > part of the Vim editor's package, which -- as far as I know -- is not
> > currently declared as a build dependency of GCC?
>
> We have a patch, which check
On Wed, Jul 08, 2015 at 16:16:44 +0200, Thomas Schwinge wrote:
> > --- /dev/null
> > +++ b/liboffloadmic/plugin/Makefile.am
> > @@ -0,0 +1,123 @@
> > +# Plugin for offload execution on Intel MIC devices.
>
> > +main_target_image.h: offload_target_main
> > + @echo -n "const int image_size = " > $
Hi!
On Wed, 8 Jul 2015 18:13:56 +0300, Ilya Verbin wrote:
>
> > On 8 июля 2015 г., at 17:16, Thomas Schwinge
> > wrote:
> > With recent GCC trunk sources, builds of the Intel MIC Offload Plugin
> > fail as follows: [...]
> > [...] -- OK to commit the following?
> Ok to me, thanks.
Committed
> On 8 июля 2015 г., at 17:16, Thomas Schwinge wrote:
>
> Hi!
>
>> On Tue, 21 Oct 2014 21:24:13 +0400, Ilya Verbin wrote:
>> This patch contains a plugin for libgomp and appropriate changes for
>> makefiles.
>>
>> The plugin uses liboffloadmic_host.so to interact with the device (or with an
Hi!
On Tue, 21 Oct 2014 21:24:13 +0400, Ilya Verbin wrote:
> This patch contains a plugin for libgomp and appropriate changes for
> makefiles.
>
> The plugin uses liboffloadmic_host.so to interact with the device (or with an
> emulator). Also the patch contains offload_target_main executable,
Hi!
On Fri, 12 Dec 2014 10:42:30 +0100, I wrote:
> On Mon, 10 Nov 2014 17:30:38 +0300, Ilya Verbin wrote:
> > --- /dev/null
> > +++ b/liboffloadmic/plugin/Makefile.am
> > @@ -0,0 +1,123 @@
> > +# Plugin for offload execution on Intel MIC devices.
> > + AM_LDFLAGS = -L$(liboffload_dir)/.libs -L$
Hi!
On Mon, 10 Nov 2014 17:30:38 +0300, Ilya Verbin wrote:
> --- /dev/null
> +++ b/liboffloadmic/plugin/Makefile.am
> @@ -0,0 +1,123 @@
> +# Plugin for offload execution on Intel MIC devices.
> +libgomp_src_dir = $(top_srcdir)/../../libgomp
> +libgomp_dir = $(build_dir)/../../libgomp
Hmm, I'm n
On Mon, Nov 10, 2014 at 05:30:38PM +0300, Ilya Verbin wrote:
> On 06 Nov 19:25, Jakub Jelinek wrote:
> > Oh, one more point, if mic_lib_path is NULL, what is the point
> > to do the alloca/malloc and string copying? Can't you just
> > setenv (MIC_LD_LIBRARY_PATH_ENV, ld_lib_path, 1);
> > in that
On 06 Nov 19:25, Jakub Jelinek wrote:
> Oh, one more point, if mic_lib_path is NULL, what is the point
> to do the alloca/malloc and string copying? Can't you just
> setenv (MIC_LD_LIBRARY_PATH_ENV, ld_lib_path, 1);
> in that case early?
>
> Otherwise LGTM.
Done.
Thanks,
-- Ilya
---
diff
On Mon, Oct 27, 2014 at 03:15:56PM +0300, Ilya Verbin wrote:
> + bool use_alloca;
> + const char *ld_lib_path = getenv (LD_LIBRARY_PATH_ENV);
> + const char *mic_lib_path = getenv (MIC_LD_LIBRARY_PATH_ENV);
> + char *mic_lib_path_new;
> + size_t len;
> +
> + if (!ld_lib_path)
> +return;
On 24 Oct 17:18, Jakub Jelinek wrote:
> On Fri, Oct 24, 2014 at 07:08:44PM +0400, Ilya Verbin wrote:
> > On 24 Oct 16:35, Jakub Jelinek wrote:
> > > On Thu, Oct 23, 2014 at 07:41:12PM +0400, Ilya Verbin wrote:
> > > > > malloc can fail, SIGSEGV in response to that is not desirable.
> > > > > Can't
On Fri, Oct 24, 2014 at 07:08:44PM +0400, Ilya Verbin wrote:
> On 24 Oct 16:35, Jakub Jelinek wrote:
> > On Thu, Oct 23, 2014 at 07:41:12PM +0400, Ilya Verbin wrote:
> > > > malloc can fail, SIGSEGV in response to that is not desirable.
> > > > Can't you fallback to alloca, or use just alloca, or u
On 24 Oct 16:35, Jakub Jelinek wrote:
> On Thu, Oct 23, 2014 at 07:41:12PM +0400, Ilya Verbin wrote:
> > > malloc can fail, SIGSEGV in response to that is not desirable.
> > > Can't you fallback to alloca, or use just alloca, or use alloca
> > > with malloc fallback?
> >
> > I replaced it with all
On Thu, Oct 23, 2014 at 07:41:12PM +0400, Ilya Verbin wrote:
> > malloc can fail, SIGSEGV in response to that is not desirable.
> > Can't you fallback to alloca, or use just alloca, or use alloca
> > with malloc fallback?
>
> I replaced it with alloca.
There is a risk if a suid or otherwise privi
On 22 Oct 11:22, Jakub Jelinek wrote:
> On Tue, Oct 21, 2014 at 09:24:13PM +0400, Ilya Verbin wrote:
> > + mic_lib_path_new = (char *) malloc ((mic_lib_path ? strlen
> > (mic_lib_path) : 0)
> > + + strlen (ld_lib_path) + 2);
>
> malloc can fail, SIGSEGV in respons
On Tue, Oct 21, 2014 at 09:24:13PM +0400, Ilya Verbin wrote:
> +/* Add path specified in LD_LIBRARY_PATH to MIC_LD_LIBRARY_PATH, which is
> + required by liboffloadmic. */
> +__attribute__((constructor))
> +static void
> +set_mic_lib_path (void)
> +{
> + const char *ld_lib_path = getenv (LD_LIB
Hello,
This patch contains a plugin for libgomp and appropriate changes for makefiles.
The plugin uses liboffloadmic_host.so to interact with the device (or with an
emulator). Also the patch contains offload_target_main executable, which is the
corresponding target side part of a libgomp plugin,
26 matches
Mail list logo
