Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-29 Thread Trevor Saunders
On Mon, Aug 29, 2016 at 02:53:43PM -0400, David Malcolm wrote: > On Sun, 2016-08-28 at 11:13 -0400, Trevor Saunders wrote: > > On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > > > + > > > + const char *m_filename; > > > + char *m_content; > > > + size_t m_len; > > > + size_t m_a

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-29 Thread David Malcolm
On Sun, 2016-08-28 at 11:13 -0400, Trevor Saunders wrote: > On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > > This version removes edit_context::apply_changes and related > > functionality, retaining the ability to generate diffs. > > > > It also improves error-handling (adding a

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-28 Thread Trevor Saunders
On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > This version removes edit_context::apply_changes and related > functionality, retaining the ability to generate diffs. > > It also improves error-handling (adding a selftest for this). > > gcc/ChangeLog: > * Makefile.in (OBJS-

[PATCH 3/4] (v2) Introduce class edit_context

2016-08-24 Thread David Malcolm
This version removes edit_context::apply_changes and related functionality, retaining the ability to generate diffs. It also improves error-handling (adding a selftest for this). gcc/ChangeLog: * Makefile.in (OBJS-libcommon): Add edit-context.o. * diagnostic-color.c (color_dict):