Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-31 Thread Paul Koning
> On Aug 30, 2018, at 9:02 PM, Jeff Law wrote: > > On 08/30/2018 10:58 AM, Richard Henderson wrote: >> On 08/28/2018 07:13 AM, Jeff Law wrote: >>> Please consider using function descriptors rather than trampolines. >>> This allows you to make the stack non-executable at all times which is >>>

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-30 Thread Jeff Law
On 08/30/2018 10:58 AM, Richard Henderson wrote: > On 08/28/2018 07:13 AM, Jeff Law wrote: >> Please consider using function descriptors rather than trampolines. >> This allows you to make the stack non-executable at all times which is >> good from a security standpoint. The downside is the indire

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-30 Thread Richard Henderson
On 08/28/2018 07:13 AM, Jeff Law wrote: > Please consider using function descriptors rather than trampolines. > This allows you to make the stack non-executable at all times which is > good from a security standpoint. The downside is the indirect calling > mechanism has to change slightly to disti

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-30 Thread Joseph Myers
On Thu, 30 Aug 2018, Stafford Horne wrote: > On Wed, Aug 29, 2018 at 04:38:45PM -0600, Jeff Law wrote: > > ps. Any plans for glibc? How complete is the qemu support? I'm having > > reasonable success building little chroot filesystems, then using qemu > > to do bootstrap testing within those chr

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Stafford Horne
On Wed, Aug 29, 2018 at 04:38:45PM -0600, Jeff Law wrote: > ps. Any plans for glibc? How complete is the qemu support? I'm having > reasonable success building little chroot filesystems, then using qemu > to do bootstrap testing within those chroots. Hello Juff, I was planning to start to look

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Richard Henderson
On 08/29/2018 03:38 PM, Jeff Law wrote: > As far as I'm concerned, you can commit this once the barriers & > speculation bits are fixed. If you can avoid trampolines, that can be a > follow-up. And long branches can definitely be punted until it's really > needed. Thanks. > ps. Any plans for gl

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Stafford Horne
On Wed, Aug 29, 2018 at 02:29:45PM -0700, Richard Henderson wrote: > On 08/28/2018 07:13 AM, Jeff Law wrote: > > I didn't see any provision for long vs short branches. How are branches > > to targets within the same function, but which are out of the range that > > can be encoded in a single instr

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Jeff Law
On 08/29/2018 04:38 PM, Jeff Law wrote: > On 08/29/2018 03:29 PM, Richard Henderson wrote: > > As far as I'm concerned, you can commit this once the barriers & > speculation bits are fixed. If you can avoid trampolines, that can be a > follow-up. And long branches can definitely be punted until

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Jeff Law
On 08/29/2018 03:29 PM, Richard Henderson wrote: > On 08/28/2018 07:13 AM, Jeff Law wrote: >> Your port defines instruction scheduling, so please check that you're >> emitting the proper barriers, particularly in your epilogue code. In >> particular most ports need a barrier to prevent movement of

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Stafford Horne
On Tue, Aug 28, 2018 at 08:13:48AM -0600, Jeff Law wrote: > On 08/26/2018 03:18 PM, Stafford Horne wrote: > > -mm-dd Stafford Horne > > Richard Henderson > > > > gcc/ChangeLog: > > > > * common/config/or1k/or1k-common.c: New file. > > * config/or1k/*: New. > > * confi

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-29 Thread Richard Henderson
On 08/28/2018 07:13 AM, Jeff Law wrote: > Your port defines instruction scheduling, so please check that you're > emitting the proper barriers, particularly in your epilogue code. In > particular most ports need a barrier to prevent movement of register > restores past the stack adjustment when th

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-28 Thread Jeff Law
On 08/26/2018 03:18 PM, Stafford Horne wrote: > -mm-dd Stafford Horne > Richard Henderson > > gcc/ChangeLog: > > * common/config/or1k/or1k-common.c: New file. > * config/or1k/*: New. > * config.gcc (or1k*-*-*): New. > * configure.ac (or1k*-*-*): New test

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-28 Thread Stafford Horne
Hi Joseph, On Mon, Aug 27, 2018 at 05:24:51PM +, Joseph Myers wrote: > On Mon, 27 Aug 2018, Stafford Horne wrote: > > > gcc/config/or1k/elf.opt | 33 + > > > gcc/config/or1k/or1k.opt | 41 + > > Command-line options need documenting in invoke.texi. This patch i

Re: [PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-27 Thread Joseph Myers
On Mon, 27 Aug 2018, Stafford Horne wrote: > gcc/config/or1k/elf.opt | 33 + > gcc/config/or1k/or1k.opt | 41 + Command-line options need documenting in invoke.texi. This patch is missing documentation updates. Please see sourcebuild.texi, section "Back End", for

[PATCH 3/3] or1k: gcc: initial support for openrisc

2018-08-26 Thread Stafford Horne
-mm-dd Stafford Horne Richard Henderson gcc/ChangeLog: * common/config/or1k/or1k-common.c: New file. * config/or1k/*: New. * config.gcc (or1k*-*-*): New. * configure.ac (or1k*-*-*): New test for openrisc tls. * configure: Regenerated. -